Make zoom-meeting-webhook-handler participant.joined and participant.left retry logic into a background function#21
Open
ebanner wants to merge 3 commits intoVirtual-Coffee:mainfrom
Conversation
ebanner
force-pushed
the
put-partipant-joined-left-retry-logic-into-background-function
branch
from
c56de2c to
341f0ad
Compare
…ckground function This change makes it so we fire off a request to the participant joined/left retry logic in a background function then return immediately to zoom in zoom-meeting-webhook-handler so zoom doesn't send a retry request Currently, we perform retry logic within the initial zoom request in zoom-meeting-webhook-handler, which is ostensibly causing zoom to time out
ebanner
force-pushed
the
put-partipant-joined-left-retry-logic-into-background-function
branch
from
341f0ad to
9bc6788
Compare
Contributor
Author
|
By the way, I drew out a diagram of some data that gets passed around in order to figure out what needed to get passed to the worker function. I'll leave it here in case anyone finds it useful.
|
ebanner
changed the title
participant.joined and participant.left retry logic into a background functionparticipant.joined and participant.left retry logic into a background function
ebanner
force-pushed
the
put-partipant-joined-left-retry-logic-into-background-function
branch
from
44316ea to
2e9b362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
This change makes it so we fire off a request to the participant joined/left retry logic in a background function then return immediately to zoom so zoom doesn't send a retry request
Currently, we perform retry logic within the initial zoom request, which is ostensibly causing zoom to time out
As a note, I kept this PR as two separate commits because I like to have the first commit as close to a copy-paste with little changes as possible to put the retry logic into a background function in the git history. Then the next commit cleans it up a bit
I assume
APP_HOSTis set on prod, but I'm not 100% sure. We need to make sure it's set