Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for this. This is a massive sleeper application with a regex engine support range I haven't seen anywhere else.
While this PR includes several commits each commit should be largely singular and able to stand on its own.
Nothing here is groundbreaking although the centralized exception handling touches a ton of code so I didn't want to let it age and potentially develop conflicts.
Feel free to reject any of this. In terms of the exception handling the alternative would be to throw some more specific exception types, then rather than debugger.break just using VS first chance exception intercept on the types you care about to break before that.
Otherwise I tried to start consolidating debug control flow in the new InternalConfig class.
I realize as well this does cause a few style issues vs the original. These can be refined but if you don't like the fluent styling I figure not waste time on refining the style to be more polished.