Skip to content

Conversation

@mitchcapper
Copy link

@mitchcapper mitchcapper commented Nov 26, 2025

First, thank you for this. This is a massive sleeper application with a regex engine support range I haven't seen anywhere else.

While this PR includes several commits each commit should be largely singular and able to stand on its own.

Nothing here is groundbreaking although the centralized exception handling touches a ton of code so I didn't want to let it age and potentially develop conflicts.

Feel free to reject any of this. In terms of the exception handling the alternative would be to throw some more specific exception types, then rather than debugger.break just using VS first chance exception intercept on the types you care about to break before that.

Otherwise I tried to start consolidating debug control flow in the new InternalConfig class.

I realize as well this does cause a few style issues vs the original. These can be refined but if you don't like the fluent styling I figure not waste time on refining the style to be more polished.

@Viorel
Copy link
Owner

Viorel commented Dec 31, 2025

Thank you for the extraordinary attention. The suggestions mentioned in pull requests are valuable and deserve to be accepted.

However, I would prefer for rough and imperfect version to coexist here. I think it's a good idea for improvements to be made in a separate repository. Perhaps the contrast between implementations could even be an advantage. I will definitely include a reference to the superior alternative in the README.

@mitchcapper
Copy link
Author

It is clear you have put an incredible amount of time into the project, I like to contribute back when I can. I would be fine refining some of these things if useful (or say skipping the theme/style changes assuming that is the big objection). Of course if it is more just not your direction on these things no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants