Skip to content

Fix vt_data auto-update inconsistency and hardware zone bugs#358

Merged
No0ne558 merged 2 commits intoViewTouch:masterfrom
No0ne558:master
Feb 12, 2026
Merged

Fix vt_data auto-update inconsistency and hardware zone bugs#358
No0ne558 merged 2 commits intoViewTouch:masterfrom
No0ne558:master

Conversation

@No0ne558
Copy link
Contributor

Description:

This PR addresses two critical bugs in the ViewTouch POS system:

Changes

1. Fix vt_data auto-update inconsistency between server and external displays

  • Problem: The vt_data auto-update feature worked correctly on server displays but incorrectly updated on external displays, even when disabled in settings.
  • Root Cause: The auto-update setting was loaded using display-specific data paths, causing inconsistent behavior between server and external displays.
  • Solution: Modified manager.cc to load the auto_update_vt_data setting from a fixed path (settings.dat) instead of using the display-dependent data_path.
  • Impact: Ensures consistent auto-update behavior across all display types.

2. Fix Hardware zone bugs: duplicate server terminals and shared printer removal

  • Problem: Hardware zones had issues with duplicate server terminals appearing and improper removal of shared printers.
  • Root Cause: Logic errors in zone management and printer sharing code.
  • Solution: Updated hardware_zone.cc and settings.cc to properly handle server terminal uniqueness and shared printer cleanup.
  • Impact: Prevents duplicate terminals and ensures proper printer management in multi-zone setups.

Files Modified

  • manager.cc: Updated auto-update settings loading logic
  • hardware_zone.cc: Fixed server terminal and printer sharing logic
  • settings.cc: Improved server terminal management
  • changelog.md: Added documentation for both fixes

Testing

  • Verified auto-update setting consistency across display types
  • Confirmed hardware zone operations work correctly without duplicates
  • All changes maintain backward compatibility

Commits

  • 814eda3: Fix vt_data auto-update inconsistency between server and external displays
  • ebc9581: Fix Hardware zone bugs: duplicate server terminals and shared printer removal

… removal

- Fix FindServer to properly identify server terminals and prevent duplicates
- Add IsPrinterShared method to check if printer is used by multiple terminals
- Modify KillRecord to only remove printer if not shared by other terminals
- Update changelog with bug fixes
@No0ne558 No0ne558 merged commit 3b295e4 into ViewTouch:master Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant