Fix #245: Resolve unexpected teleport confirmation ID kick on 1.9+ servers#254
Open
Ghost-Kokoro wants to merge 1 commit intoViaVersion:masterfrom
Open
Fix #245: Resolve unexpected teleport confirmation ID kick on 1.9+ servers#254Ghost-Kokoro wants to merge 1 commit intoViaVersion:masterfrom
Ghost-Kokoro wants to merge 1 commit intoViaVersion:masterfrom
Conversation
florianreuth
requested changes
Mar 21, 2026
Member
florianreuth
left a comment
There was a problem hiding this comment.
Is this tested? Pretty sure ViaRewind will already read the teleport id away (MixinS08PacketPlayerPosLook) as the vanilla client would otherwise get kicked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #245, where 1.8.9 clients get kicked with the error
Unexpected teleport confirmation idwhen playing on 1.9+ servers.Root Cause
In 1.9+ protocols, servers append a
teleportIdtoS08PacketPlayerPosLookand mandate anACCEPT_TELEPORTATIONresponse before processing subsequent client movements. Since pure 1.8.9 clients lack this logic, the teleport ID mismatch or omission causes the server to either infinitely rubberband the player or outright kick them for sending invalid confirmation IDs.Closes #245