Skip to content

Fix #245: Resolve unexpected teleport confirmation ID kick on 1.9+ servers#254

Open
Ghost-Kokoro wants to merge 1 commit intoViaVersion:masterfrom
Ghost-Kokoro:fix/1.9-teleport-deadlock
Open

Fix #245: Resolve unexpected teleport confirmation ID kick on 1.9+ servers#254
Ghost-Kokoro wants to merge 1 commit intoViaVersion:masterfrom
Ghost-Kokoro:fix/1.9-teleport-deadlock

Conversation

@Ghost-Kokoro
Copy link

Description

This PR addresses Issue #245, where 1.8.9 clients get kicked with the error Unexpected teleport confirmation id when playing on 1.9+ servers.

Root Cause

In 1.9+ protocols, servers append a teleportId to S08PacketPlayerPosLook and mandate an ACCEPT_TELEPORTATION response before processing subsequent client movements. Since pure 1.8.9 clients lack this logic, the teleport ID mismatch or omission causes the server to either infinitely rubberband the player or outright kick them for sending invalid confirmation IDs.

Closes #245

Copy link
Member

@florianreuth florianreuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested? Pretty sure ViaRewind will already read the teleport id away (MixinS08PacketPlayerPosLook) as the vanilla client would otherwise get kicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C1.8.9 to S1.12.2 : Unexpected teleport confirmation id : 3

2 participants