feat: add --collect-coverage-from option to include untested files in coverage#1457
Open
meylis1998 wants to merge 3 commits intoVeryGoodOpenSource:mainfrom
Open
feat: add --collect-coverage-from option to include untested files in coverage#1457meylis1998 wants to merge 3 commits intoVeryGoodOpenSource:mainfrom
meylis1998 wants to merge 3 commits intoVeryGoodOpenSource:mainfrom
Conversation
4485b0f to
0aff007
Compare
68fc1f2 to
7e22015
Compare
LCOV format expects Unix-style forward slashes in file paths. On Windows, p.relative() returns backslash-separated paths, causing test failures when comparing LCOV output.
Contributor
Author
|
Hey @marcossevilla! 👋 When you get a chance, would you mind taking a look at this PR? I'd really appreciate your feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements feature request #418 to add a
--collect-coverage-fromoption that allows users to choose whether coverage is collected from imported files only or all files in the project.Changes
CoverageCollectionModeenum withimports(default) andallmodes--collect-coverage-fromoption to both Flutter and Dart test commands--exclude-coverageand--report-onoptionsUsage Examples
Key Features
importsmode)--exclude-coverageFiles Modified
lib/src/cli/test_cli_runner.dart- Core implementationlib/src/commands/test/test.dart- Flutter test commandlib/src/commands/dart/commands/dart_test_command.dart- Dart test commandlib/src/cli/flutter_cli.dart- Flutter CLI integrationlib/src/cli/dart_cli.dart- Dart CLI integrationtest/src/commands/test/test_test.dart- Flutter test updatestest/src/commands/dart/commands/dart_test_test.dart- Dart test updatesCloses #418