Update facet-cut-params-generator to handle add and replace selectors dynamically#629
Merged
GitGuru7 merged 2 commits intofeat/vpd-893-bounded-price-oraclefrom Apr 30, 2026
Merged
Conversation
Debugger022
reviewed
Oct 14, 2025
| const newFacetAddress = newFacetAddresses[facetName]; | ||
|
|
||
| // Current facet selectors (from diamond, assuming the facet addresses in the same order as newFacetAddresses) | ||
| const currentSelectors: string[] = facetName === "FacetBase" ? [] : currentFacets[i].functionSelectors; |
Contributor
There was a problem hiding this comment.
What if the diamond's facet order differs from FacetNames?
Debugger022
reviewed
Oct 14, 2025
|
|
||
| // New facet selectors (from interface) | ||
| const newFacetInterface = await ethers.getContractAt(FacetsInterfaces[facetName], newFacetAddress); | ||
| const newSelectors: string[] = getSelectors(newFacetInterface); |
Contributor
There was a problem hiding this comment.
Are there any chances that getSelectors could fail?
GitGuru7
changed the base branch from
feat/VEN-3361
to
feat/vpd-893-bounded-price-oracle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
facet-cut-params-generatorscript to improve how diamond cut parameters are generated:The script now fetches the current function selectors from the deployed diamond contract.
It generates the final cut-params array, considering both Add and Replace operations dynamically.
For
IFacetBaseselectors:Note: Now onwards when running the script, please use the
--networkflag to specify the target network.