Skip to content

Conversation

@bencap
Copy link
Collaborator

@bencap bencap commented Dec 13, 2025

This pull request enhances the display of external links in the ScoreSetSecondaryMetadata.vue component by adding support for the IGVF Portal and improving the styling for external link sections.

External Link Integration and Styling:

  • Added a new external link section for the IGVF Portal, including an IGVF logo and appropriate link styling.
  • Updated the UCSC Genome Browser link to use consistent styling and adjusted the logo display.
  • Introduced new CSS classes to ensure external links are visually distinct, aligned, and consistently sized.

Adds a home page note about linkage to the IGVF data portal
Screenshot 2025-12-16 at 1 35 51 PM

Adds a link to the IGVF data portal for score sets when available
Screenshot 2025-12-16 at 1 38 32 PM

Adds a link to the experiment page for IGVF portal access
Screenshot 2025-12-16 at 1 57 16 PM

Link-ifies collection links, which will allow us to point users to the IGVF catalog when applicable
Screenshot 2025-12-16 at 1 35 09 PM

  • Note that these links are properly sanitized and escaped to prevent XSS

Prior features mean we already have the functionality to add an IGVF logo to the top of score set and experiment pages when they are part of an official collection.
Screenshot 2025-12-16 at 1 41 54 PM

@bencap bencap linked an issue Dec 13, 2025 that may be closed by this pull request
@bencap bencap requested review from jstone-dev and sallybg December 16, 2025 21:42
@bencap bencap marked this pull request as ready for review December 16, 2025 21:42
@bencap bencap force-pushed the feature/bencap/dedicated-igvf-linkout branch from b1607f1 to 7e29e2e Compare December 16, 2025 21:56
@bencap bencap changed the base branch from release-2025.5.3 to release-2025.6.0 January 5, 2026 22:13
@bencap bencap requested a review from davereinhart January 6, 2026 18:25
@davereinhart davereinhart force-pushed the feature/bencap/dedicated-igvf-linkout branch from 4e23732 to cff8985 Compare January 7, 2026 17:10
Copy link
Contributor

@davereinhart davereinhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to review, I rebased against the latest release-2025.6.0, and made a few other changes to fix alignment of img elements.

After that, changes look good to me. Only comment is we might consider using a package like linkify in place of linkifyTextHtml function.

@bencap
Copy link
Collaborator Author

bencap commented Jan 8, 2026

After that, changes look good to me. Only comment is we might consider using a package like linkify in place of linkifyTextHtml function.

I integrated linkifyHtml, but retained our function since linkifyHtml doesn't provide any text sanitation. But at least we don't need to maintain the actual link-ification.

@bencap bencap merged commit 650d498 into release-2025.6.0 Jan 14, 2026
@bencap bencap deleted the feature/bencap/dedicated-igvf-linkout branch January 14, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IGVF Dedicated Linkout

3 participants