-
Notifications
You must be signed in to change notification settings - Fork 2
feat: handle IGVF external links #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle IGVF external links #596
Conversation
b1607f1 to
7e29e2e
Compare
Reflects changes in VariantEffect/mavedb-api#619
…ew and CollectionsView
The relative import of the IGVF badge icon was sufficient for local development, but the badge icon was not being found by the built package.
4e23732 to
cff8985
Compare
davereinhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to review, I rebased against the latest release-2025.6.0, and made a few other changes to fix alignment of img elements.
After that, changes look good to me. Only comment is we might consider using a package like linkify in place of linkifyTextHtml function.
…n linkifyTextHtml function
I integrated linkifyHtml, but retained our function since linkifyHtml doesn't provide any text sanitation. But at least we don't need to maintain the actual link-ification. |
This pull request enhances the display of external links in the
ScoreSetSecondaryMetadata.vuecomponent by adding support for the IGVF Portal and improving the styling for external link sections.External Link Integration and Styling:
Adds a home page note about linkage to the IGVF data portal

Adds a link to the IGVF data portal for score sets when available

Adds a link to the experiment page for IGVF portal access

Link-ifies collection links, which will allow us to point users to the IGVF catalog when applicable

Prior features mean we already have the functionality to add an IGVF logo to the top of score set and experiment pages when they are part of an official collection.
