fix: send subscribe form as urlencoded so Customer.io records form_submit#1045
Closed
betzlermeow wants to merge 1 commit intomainfrom
Closed
fix: send subscribe form as urlencoded so Customer.io records form_submit#1045betzlermeow wants to merge 1 commit intomainfrom
betzlermeow wants to merge 1 commit intomainfrom
Conversation
…bmit The whats-new subscribe form posts to Customer.io's submit_action endpoint, which expects application/x-www-form-urlencoded (the encoding native HTML form POSTs use). Commit 6cce858 replaced the native submit with a fetch() that sent FormData (multipart/form-data); the endpoint accepts the request and returns the 302, but does not record a form_submit event, so no one is added to the subscriber segment. The opaqueredirect response made the UI report success regardless. Switch the body to URLSearchParams so the request matches the encoding the endpoint actually processes. Add regression tests pinning the body type.
Contributor
|
🌿 Preview your docs: https://vapi-preview-b69fded0-32d1-4d81-ac2f-a9cf68d12eab.docs.buildwithfern.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing — investigation determined the integration is working as expected. Form submissions are reaching Customer.io and recording on the Forms integration's Submissions tab; the original symptom (no
form_submitevents in Activity Log filter) was a misread of the dashboard, not a real outage.No code change needed.