[ALL] Fix maps with multiple 3d skyboxes rendering all of them at the same time #1849
Open
gidi30 wants to merge 1 commit intoValveSoftware:masterfrom
Open
[ALL] Fix maps with multiple 3d skyboxes rendering all of them at the same time #1849gidi30 wants to merge 1 commit intoValveSoftware:masterfrom
gidi30 wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently in maps with multiple 3d skyboxes in them all of them render at the same time even if they completely seperate.
This is caused by a call to BuildWorldRenderLists in CSkyboxView::DrawInternal listing the arguments in the wrong order causing the ViewLeaf the sky is rendered from to be set to 1 instead of being calculated based on the origin and area of the camera.
Before
2026-03-22.10-31-39.mp4
After
2026-03-22.10-33-58.mp4