Linux: leave the default symbol visibility to improve modding with tools #3852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3562
At first I thought it might be because of the lack of
-Wl,--export-dynamicand-fPICas linker flags, although adding them had no effect. Then I started to lower the optimization levels, suspecting that this was due to the highest optimization level - that's not the issue either. Flags for debug information in the form-gdwarf-2 -g2were also enabled.Until I noticed -fvisibility=hidden and then it became clear to me why most of the function symbols in the
.dynsymsection were missing. Yeah....@shawns-valve - these changes should also be applied to the engine as well, not just to game libraries!