fix: dd over a single line holding a folded block now deletes the whole block #9933#9934
Open
escoberik wants to merge 1 commit intoVSCodeVim:masterfrom
Open
fix: dd over a single line holding a folded block now deletes the whole block #9933#9934escoberik wants to merge 1 commit intoVSCodeVim:masterfrom
escoberik wants to merge 1 commit intoVSCodeVim:masterfrom
Conversation
…le block instead of just the line
escoberik
force-pushed
the
dd-should-affect-folded-blocks
branch
from
51f6ca6 to
14dc46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Typing
ddover a line holding a folded block now deletes the whole folded block instead of just that line.This behavior matches better what vim does.
Which issue(s) this PR fixes
#9933 also includes
yybut this PR only fixesddso it won't actually closes the issue.Special notes for your reviewer:
This is my first PR so I'm not sure I'm on the right path but if it looks good I can fix
yyas well.