pyJWT + urllib instrumentations #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 20 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/core/content_type_utils.py">
<violation number="1" location="drift/core/content_type_utils.py:116">
P3: The comment above ACCEPTABLE_DECODED_TYPES is now inaccurate because HTML was added to the allowed set. Update the comment to reflect that HTML is also acceptable.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
When urllib raises HTTPError for 4xx/5xx responses, the instrumentation now correctly replays this by raising HTTPError instead of returning a normal MockHTTPResponse. This ensures application code catching HTTPError behaves the same in RECORD and REPLAY modes. - Add _raise_http_error_from_mock method to reconstruct HTTPError - Check for errorName in _try_get_mock and raise appropriately - Re-raise HTTPError/URLError exceptions to propagate correctly
When urllib follows redirects, response.geturl() should return the final URL after all redirects. The instrumentation now: - Captures finalUrl in RECORD mode when it differs from request URL - Uses finalUrl in REPLAY mode so MockHTTPResponse.geturl() returns the correct final URL instead of the original request URL This ensures application code that checks the final URL after redirects behaves the same in RECORD and REPLAY modes.
Extract shared logic into helper methods: - _build_input_value(): constructs HTTP request input value dict - _build_input_schema_merges(): creates schema merge hints for headers/body Both RECORD (_finalize_span) and REPLAY (_try_get_mock) modes now use these helpers, eliminating ~60 lines of duplicate code and ensuring consistent behavior between modes.
There was a problem hiding this comment.
3 issues found across 3 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/urllib/instrumentation.py">
<violation number="1" location="drift/instrumentation/urllib/instrumentation.py:783">
P2: Recorded URLError exceptions are not re-raised during replay. The new error handling only raises HTTPError, so URLError recordings fall through to a 200 OK mock response, hiding failures and changing application behavior. Handle URLError (and other urllib errors) similarly to HTTPError so replay matches record behavior.</violation>
</file>
<file name="drift/instrumentation/urllib/e2e-tests/src/test_requests.py">
<violation number="1" location="drift/instrumentation/urllib/e2e-tests/src/test_requests.py:102">
P2: The "HEAD request" test uses GET, so it won’t exercise HEAD-specific behavior. Use the HEAD method to match the test intent.</violation>
<violation number="2" location="drift/instrumentation/urllib/e2e-tests/src/test_requests.py:105">
P2: The "OPTIONS request" test uses GET, so it won’t exercise OPTIONS-specific behavior. Use the OPTIONS method to match the test intent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sohil-kshirsagar
approved these changes
Jan 19, 2026
jy-tan
approved these changes
Jan 19, 2026
Contributor
jy-tan
left a comment
jy-tan
left a comment
There was a problem hiding this comment.
Remember to update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds new HTTP client coverage and replay robustness while aligning error/content-type rules.
urllib.requestclient instrumentation (record/replay, body caching, transforms, mock fallback) with comprehensive e2e test app, Docker setup, and runner_merge_options,_verify_signature,_validate_claims) to bypass during replay; auto-register in SDKurllib.requestinstrumentation; README listsPyJWTandurllib.requestsupport; type-check overrides forpyjwt>=300to>=400in Django, FastAPI, and WSGI; trace blocking updated accordinglyHTML(added to acceptable decoded types)urllib3mock responses now includefinalUrl/geturlin outputsWritten by Cursor Bugbot for commit 39b4bef. This will update automatically on new commits. Configure here.