Draft
Conversation
|
Any updates on the new version ? |
|
@joshpensky Are you planning release this anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces a rewrite of the
react-router-guardsinternals, with some public-facing API changesThis builds on top of #84, #85, #98, and #99 to make the following changes:
route.match(not location)resolving <--> (error | redirect | render)guard(context, next), where context contains the route to, from, meta, and an AbortSignal for cancelling fetchesnextis now a requirement for guard functions__RouterContexthas been removed—data returned from guards is now accessible via theuseGuardDatahookWhat this does
Describe what changes were made in more detail
How to test
Describe how to test your changes
TODO
RouterContextin favor ofuseGuardData?