Skip to content

[RAT-2480] Removing unnecessary dictionary allocation #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lopezt-unity wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1,208
Open

[RAT-2480] Removing unnecessary dictionary allocation #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ded0b
removing a 1200 entries dictionary only use for nicifying optional no…
lopezt-unity Mar 18, 2026
f878ccd
changelog
lopezt-unity Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## Unreleased

### Changes
- Removed a non-necessary utility dictionary that would allocate unnecessary large space in a build.
Copy link

@u-pr u-pr bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low
Minor nit: The phrase 'allocate unnecessary large space' is slightly unclear. Have you considered rephrasing to 'Removed a large utility dictionary to reduce binary size and runtime memory overhead' or similar?

🤖 Helpful? 👍/👎


### Fixed

- [UUM-133861] Fixed "Look rotation viewing vector is zero" log being spammed when holding shift while using a create tool such as Create Sprite.
Expand Down
2 changes: 1 addition & 1 deletion Editor/EditorCore/VertexColorPalette.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
pb.Optimize();
}

EditorUtility.ShowNotification("Set Vertex Colors\n" + ColorUtility.GetColorName(col));
EditorUtility.ShowNotification("Vertex Colors Set");

Check warning on line 219 in Editor/EditorCore/VertexColorPalette.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Editor/EditorCore/VertexColorPalette.cs#L219 

Added line #L219 was not covered by tests
}
}
}
Loading