chore: [Optimize bitfield accessors] NetworkTransform#3907
Open
noellie-velez wants to merge 2 commits intodevelop-2.0.0from
Open
chore: [Optimize bitfield accessors] NetworkTransform#3907noellie-velez wants to merge 2 commits intodevelop-2.0.0from
noellie-velez wants to merge 2 commits intodevelop-2.0.0from
Conversation
noellie-velez
commented
Mar 18, 2026
| // We compare against the NetworkTickSystem version since ServerTime is set when updating ticks | ||
| if (UseUnreliableDeltas && !isSynchronization && m_DeltaSynch && m_NextTickSync <= CurrentTick) | ||
| { | ||
| // TODO-CACHE: m_CachedNetworkManager.NetworkConfig.TickRate value |
Collaborator
Author
There was a problem hiding this comment.
m_CachedNetworkManager.NetworkConfig.TickRate is used only once in this script, why would we cache it?
noellie-velez
commented
Mar 18, 2026
| { | ||
| if (networkTransform.NetworkManager == null) | ||
| //CHECK static context, can we use NetworkManager.Singleton? | ||
| var networkManager = networkTransform.NetworkManager; |
Collaborator
Author
There was a problem hiding this comment.
Same here:
If we are in static context, does it mean we are using NetworkManager.Singleton? If that's so, shouldn't we use that one instead of networkTransform.NetworkManager?
noellie-velez
commented
Mar 18, 2026
|
|
||
| if (!networkTransform.NetworkManager.DistributedAuthorityMode && !s_NetworkTickRegistration.ContainsKey(networkTransform.NetworkManager)) | ||
| //CHECK can we use NetworkManager.Singleton instead as we are in static context? | ||
| var networkManager = networkTransform.NetworkManager; |
Collaborator
Author
There was a problem hiding this comment.
If we are in static context, does it mean we are using NetworkManager.Singleton? If that's so, shouldn't we use that one instead of networkTransform.NetworkManager?
noellie-velez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
MTT-14675
Changelog
NetworkAnimator.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A