chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

NoelStephensUnity · 2026-01-26T20:45:23Z

WIP-TODO:

This PR depends upon the trunk PR-89134 to be merged before determining:
- The version of trunk that PR-89134 will be included in.
This PR currently uses 6000.5.0a8 as the minimum version, for 6000.5, where the updates to account for the deprecated enum and methods in order to pass tests.
- If PR-89134 is merged into 6000.5.0a7, then one more adjustment to the asmdef files will be required.

Purpose of this PR

Making adjustments to the changes in FindObjectsByType. Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

Jira ticket

MTT-14339

Changelog

Changed: Updating usage of deprecated FindObjectsByType(FindObjectsSortMode) and enum FindObjectSortMode.

Documentation

No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

Manual testing done
- Verify earlier versions of 6000.4 and 6000.5 work as expected
  - Open test project in 6000.4.b5 or earlier to verify NGO uses the (now deprecated) UnityEngine.FindObjectsSortMode.
  - Open test project in 6000.5.a6 or earlier to verify NGO uses the (now deprecated) UnityEngine.FindObjectsSortMode.
- Verify newer versions of 6000.4 and 6000.5 work as expected
  - Open test project in 6000.4.b6 or later to verify NGO no longer uses UnityEngine.FindObjectsSortMode.
  - (WIP) Open test project in 6000.5.a7/a8 or later to verify NGO no longer uses UnityEngine.FindObjectsSortMode.
    - Waiting on PR-89134.

Automated tests:

Covered by existing automated tests
Covered by new automated tests

Does the change require QA team to:

Review automated tests?
Execute manual tests?
Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port required since this is specific to 6000.4 & 6000.5.

Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

Making FindObjects internal.

Adjusted to explicit handling of the update within test project script to avoid having to make FindObjects public.

Adding [MethodImpl(MethodImplOptions.AggressiveInlining)] attribute to the T[] FindObjectsByType<T>() method.

Removing unused using directives. Removing CR.

EmandM

I love love love this cleanup!

com.unity.netcode.gameobjects/Runtime/Core/FindObjects.cs

com.unity.netcode.gameobjects/Tests/Runtime/Prefabs/NetworkPrefabHandlerTests.cs

testproject/Assets/Tests/Manual/SceneTransitioningAdditive/NetworkManagerMonitor.cs

testproject/Assets/Tests/Manual/Scripts/NetworkPrefabPool.cs

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

Adding same condition define, NGO_FINDOBJECTS_NOSORTING, to the testproject.manualtests assembly define.

Added more precise Unity engine versions to asmdef files to assure earlier versions of 6000.4 and 6000.5 still use the previous API. Renamed FindObjects.FindObjectsByType to FindObjects.ByType Updated FindObject.ByType to be able to sort by identifier and include inactive objects.

…ting-update

Adding sort by identifier to two locations that require sorting by identifier.

Added missing whitespace

increasing the 6000.5 version from 5.0a6 to 5.0a7 as it appears trunk is currently 5.0a6 (which doesn't have the deprecation merged into it yet).

updating minimum for deprecated fix to 6000.5.0a8.

RikuTheFuffs · 2026-01-28T13:34:12Z

com.unity.netcode.gameobjects/Runtime/Unity.Netcode.Runtime.asmdef

+        },
+        {
+            "name": "Unity",
+            "expression": "[6000.4.0b5,6000.5.0a1)",
+            "define": "NGO_FINDOBJECTS_NOSORTING"
+        },
+        {
+            "name": "Unity",
+            "expression": "6000.5.0a8",
+            "define": "NGO_FINDOBJECTS_NOSORTING"


I see you implemented this retro-compatibility fix to avoid compilation errors on alpha/beta versions that didn't have the deprecation change yet, but do we intend to support those versions in the long run?

The risk I foresee is that we fill our code with a bunch of defines for "almost-dead code", with an increased maintenance burden for us, and higher rissk to introduce bugs as we have to support multiple workflows.

Making it work with earlier versions actually prevents users that have yet to upgrade their editor from breaking if they decide to upgrade to the current version of NGO (whichever version that will be once this PR is merged). Otherwise, it would be considered a breaking change for earlier 6000.4 & 6000.5 versions.

But yeah... that is a good point and one of the reasons why I migrated all of the changes into the single FindObjects.ByType<T> method... so there is one place that handles this which also reduces the number of times we have to use the conditional define.

Test project had two places that I added this to in order to prevent from having to make FindObjects public.

We also do the work to remove the scripting defines once we no longer support that Unity version. So these defines won't live forever

EmandM

I love love love the latest name here!

This "should" fix the Rust server issue... I think? (Tested local instance on 6000.5.0a7 and it passes everything)

…ting-update

adding change log entry

update

b5bff02

Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

NoelStephensUnity requested review from a team and EmandM as code owners January 26, 2026 20:45

NoelStephensUnity added 4 commits January 26, 2026 14:49

update

793bade

Making FindObjects internal.

update

c8f54c9

Adjusted to explicit handling of the update within test project script to avoid having to make FindObjects public.

update

a5719db

Adding [MethodImpl(MethodImplOptions.AggressiveInlining)] attribute to the T[] FindObjectsByType<T>() method.

style

fec5e65

Removing unused using directives. Removing CR.

EmandM reviewed Jan 26, 2026

View reviewed changes

NoelStephensUnity and others added 2 commits January 26, 2026 16:07

Update com.unity.netcode.gameobjects/Runtime/Core/FindObjects.cs

db390f5

Co-authored-by: Emma <emma.mcmillan@unity3d.com>

update

9a5d04b

Adding same condition define, NGO_FINDOBJECTS_NOSORTING, to the testproject.manualtests assembly define.

mnachury-unity approved these changes Jan 26, 2026

View reviewed changes

NoelStephensUnity added 6 commits January 27, 2026 13:13

Merge branch 'develop-2.0.0' into chore/findobjectsbytype-no-more-sor…

b52e907

…ting-update

update

1f7e70c

Adding sort by identifier to two locations that require sorting by identifier.

style

01dd8c0

Added missing whitespace

update

b53de7a

increasing the 6000.5 version from 5.0a6 to 5.0a7 as it appears trunk is currently 5.0a6 (which doesn't have the deprecation merged into it yet).

update

1a5bb4a

updating minimum for deprecated fix to 6000.5.0a8.

RikuTheFuffs reviewed Jan 28, 2026

View reviewed changes

EmandM approved these changes Jan 28, 2026

View reviewed changes

NoelStephensUnity added 3 commits January 28, 2026 14:32

update

f5f5cf2

This "should" fix the Rust server issue... I think? (Tested local instance on 6000.5.0a7 and it passes everything)

Merge branch 'develop-2.0.0' into chore/findobjectsbytype-no-more-sor…

9939aa6

…ting-update

update

5b4f42d

adding change log entry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

Uh oh!

NoelStephensUnity commented Jan 26, 2026 •

edited

Loading

Uh oh!

EmandM left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RikuTheFuffs Jan 28, 2026

Uh oh!

NoelStephensUnity Jan 28, 2026

Uh oh!

EmandM Jan 28, 2026

Uh oh!

EmandM left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

Are you sure you want to change the base?

chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857

Uh oh!

Conversation

NoelStephensUnity commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Jira ticket

Changelog

Documentation

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Backports

Uh oh!

EmandM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RikuTheFuffs Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

NoelStephensUnity Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

EmandM Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

EmandM left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NoelStephensUnity commented Jan 26, 2026 •

edited

Loading