-
Notifications
You must be signed in to change notification settings - Fork 463
chore: Small yamato tweaks to try speed up our PR trigger runs #3711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into chore/yamato-tweaks Add update of NetworkSceneManagerEventNotifications for cmb to test the whole PR trigger
…low us to only rerun failed tests
…ier unity standards check
… it last so the other two are earlier in the VM queue
… standalone and cmb retry functionality
michalChrobot
requested changes
Oct 12, 2025
…/com.unity.netcode.gameobjects into chore/yamato-tweaks
Re-added reruncount argument to build jobs Updated some comments Set CMB tests to both Playmode and Editmode
Member
|
@EmandM instead of leaving a comment I just pushed some small changes (see last commit) which were
|
michalChrobot
approved these changes
Oct 15, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
I've spent too much time staring at yamato over #3647 . Decided to see if we can tweak our PR trigger to be more efficient.
Jira ticket
n/a
Changelog
::GPUfrom theagent.typefordesktop_standalone_build,desktop_standalone_testandcmb_service_standalone_test. All of these jobs disable the GPU so they don't need a machine with a GPU (gpu machines are much rarer)desktop_standalone_test_testproject_ubuntu_il2cpp_trunkrather thandesktop_standalone_test_testproject_win_il2cpp_6000.0that way thedesktop_standalone_testand thecmb_service_standalone_testcan use the samedesktop_standalone_buildstep rather than needing two different build stepsubuntu_6000.0.ubuntu_6000.0on the nightly and weekly builds.smaller_flavorfield intest_platforms.desktopto use with lighter weight jobs (package_pack,package_tests,project_pack). I chose which jobs to use a smaller VM from looking at the machine usage stats on bokken (like I say, I stared at yamato TOO MUCH this week).upm-citoUnifiedTestRunnerfor theproject_packandproject_testjobs.Documentation
Testing & QA (How your changes can be verified during release Playtest)
No testing needed.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
Backported by #3724