NotListeningException marked obsolete + fix test

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -1488,6 +1488,7 @@ public void NetworkShow(ulong clientId)
                 {
                     NetworkLog.LogErrorServer($"[{name}] Attempted NetworkShow while not spawned.");
                 }
+                return;
             }
 
             if (!HasAuthority)
@@ -1498,13 +1499,15 @@ public void NetworkShow(ulong clientId)
                     {
                         NetworkLog.LogError($"[{name}] Only the owner-authority can change visibility when distributed authority mode is enabled!");
                     }
+                    return;
                 }
                 else
                 {
                     if (NetworkManagerOwner.LogLevel <= LogLevel.Error)
                     {
                         NetworkLog.LogError($"[{name}] Only the authority can change visibility.");
                     }
+                    return;
                 }
             }
 
@@ -1523,8 +1526,8 @@ public void NetworkShow(ulong clientId)
                     if (NetworkManagerOwner.LogLevel <= LogLevel.Error)
                     {
                         NetworkLog.LogError($"[{name}] Only the server can change visibility.");
-                        return;
                     }
+                    return;
                 }
             }
 
@@ -1591,6 +1594,7 @@ public void NetworkHide(ulong clientId)
                 {
                     NetworkLog.LogErrorServer($"[{name}] Attempted NetworkHide while {nameof(NetworkObject)} is not spawned.");
                 }
+                return;
             }
 
             if (!HasAuthority && !NetworkManagerOwner.DAHost)
@@ -1601,13 +1605,15 @@ public void NetworkHide(ulong clientId)
                     {
                         NetworkLog.LogError($"[{name}] Only the owner-authority can change visibility when distributed authority mode is enabled!");
                     }
+                    return;
                 }
                 else
                 {
                     if (NetworkManager.LogLevel <= LogLevel.Error)
                     {
                         NetworkLog.LogError($"[{name}] Only the authority can change visibility!");
                     }
+                    return;
                 }
             }
 
@@ -1756,6 +1762,7 @@ internal void SpawnInternal(bool destroyWithScene, ulong ownerClientId, bool pla
                 {
                     NetworkLog.LogError($"[{name}] {nameof(NetworkManagerOwner)} is not listening, start a server or host before spawning objects.");
                 }
+                return;
             }
 
             if ((!NetworkManagerOwner.IsServer && !NetworkManagerOwner.DistributedAuthorityMode) || (NetworkManagerOwner.DistributedAuthorityMode && !NetworkManagerOwner.LocalClient.IsSessionOwner && NetworkManagerOwner.LocalClientId != ownerClientId))
@@ -1766,13 +1773,15 @@ internal void SpawnInternal(bool destroyWithScene, ulong ownerClientId, bool pla
                     {
                         NetworkLog.LogError($"[{name}] When distributed authority mode is enabled, you can only spawn NetworkObjects that belong to the local instance! Local instance id {NetworkManagerOwner.LocalClientId} is not the same as the assigned owner id: {ownerClientId}!");
                     }
+                    return;
                 }
                 else
                 {
                     if (NetworkManagerOwner.LogLevel <= LogLevel.Error)
                     {
                         NetworkLog.LogError($"[{name}] Only server can spawn {nameof(NetworkObject)}s.");
                     }
+                    return;
                 }
             }
 
@@ -2332,17 +2341,11 @@ private void OnTransformParentChanged()
                 {
                     if (networkManager.DistributedAuthorityMode)
                     {
-                        if (NetworkManagerOwner.LogLevel <= LogLevel.Error)
-                        {
-                            NetworkLog.LogError($"[{name}][Not Owner] Only the owner-authority of child {gameObject.name}'s {nameof(NetworkObject)} component can re-parent it!");
-                        }
+                        NetworkLog.LogError($"[{name}][Not Owner] Only the owner-authority of child {gameObject.name}'s {nameof(NetworkObject)} component can re-parent it!");
                     }
                     else
                     {
-                        if (NetworkManagerOwner.LogLevel <= LogLevel.Error)
-                        {
-                            NetworkLog.LogError($"[{name}] Only the server can re-parent {nameof(NetworkObject)}s.");
-                        }
+                        NetworkLog.LogError($"[{name}] Only the server can re-parent {nameof(NetworkObject)}s.");
                     }
                 }
                 return;
@@ -3050,7 +3053,11 @@ public void Serialize(FastBufferWriter writer)
 
                 if (!writer.TryBeginWrite(writeSize))
                 {
-                    throw new OverflowException("Could not serialize SceneObject: Out of buffer space.");
+                    if (NetworkManager.Singleton.LogLevel <= LogLevel.Error)
+                    {
+                        NetworkLog.LogError("Could not serialize SceneObject: Out of buffer space.");
+                    }
+                    return;
                 }
 
                 if (HasTransform)
@@ -3137,7 +3144,11 @@ public void Deserialize(FastBufferReader reader)
                 // Try to begin reading the remaining bytes
                 if (!reader.TryBeginRead(readSize))
                 {
-                    throw new OverflowException("Could not deserialize SceneObject: Reading past the end of the buffer");
+                    if (NetworkManager.Singleton.LogLevel <= LogLevel.Error)
+                    {
+                        NetworkLog.LogError("Could not deserialize SceneObject: Reading past the end of the buffer.");
+                    }
+                    return;
                 }
 
                 if (HasTransform)
@@ -3389,6 +3400,7 @@ internal static NetworkObject Deserialize(in SerializedObject serializedObject,
                 {
                     NetworkLog.LogErrorServer($"[{networkObject.name}] Object-{networkObject.NetworkObjectId} is already spawned!");
                 }
+                return null;
             }
 
             // Invoke the non-authority local spawn method

com.unity.netcode.gameobjects/Runtime/Exceptions/NotListeningException.cs

@@ -5,6 +5,7 @@ namespace Unity.Netcode
     /// <summary>
     /// Exception thrown when the operation require NetworkManager to be listening.
     /// </summary>
+    [Obsolete("Not used anymore.")]
     public class NotListeningException : Exception
     {
         /// <summary>

testproject/Assets/Tests/Runtime/ObjectParenting/NetworkObjectParentingTests.cs

@@ -207,7 +207,7 @@ public void SetupSet(Transform rootTransform, int setIndex, NetworkManager netwo
             Assert.That(m_Pickup_NetObjs[setIndex], Is.Not.Null);
             Assert.That(m_Pickup_Back_NetObjs[setIndex], Is.Not.Null);
 
-            LogAssert.Expect(LogType.Exception, new Regex("start a server or host", RegexOptions.IgnoreCase));
+            LogAssert.Expect(LogType.Error, new Regex("start a server or host", RegexOptions.IgnoreCase));
             var cachedParent = m_Cube_NetObjs[setIndex].parent;
             m_Cube_NetObjs[setIndex].parent = m_Pickup_NetObjs[setIndex];
             Assert.That(m_Cube_NetObjs[setIndex].parent, Is.EqualTo(cachedParent), $"Transform {m_Cube_NetObjs[setIndex].parent.name} is not equal to transform {cachedParent.name}");