@@ -1473,7 +1473,6 @@ internal NetworkSceneHandle GetSceneOriginHandle()
14731473 /// Usage: Use to start sending updates for a previously hidden <see cref="NetworkObject"/> to the targeted client.<br />
14741474 /// <br />
14751475 /// Dynamically Spawned: <see cref="NetworkObject"/>s will be instantiated and spawned on the targeted client side.<br />
1476- /// CHECK comment, is a despawned object spawned on the client side? I thought it wasn't
14771476 /// In-Scene Placed: The instantiated but despawned <see cref="NetworkObject"/>s will be spawned on the targeted client side.<br />
14781477 /// <br />
14791478 /// See Also:<br />
@@ -1487,7 +1486,7 @@ public void NetworkShow(ulong clientId)
14871486 {
14881487 if ( NetworkManagerOwner . LogLevel <= LogLevel . Error )
14891488 {
1490- NetworkLog . LogErrorServer ( $ "Trying to show { name } but it is not spawned! ") ;
1489+ NetworkLog . LogErrorServer ( $ "[ { name } ] Attempted NetworkShow while not spawned. ") ;
14911490 }
14921491 }
14931492
@@ -1504,12 +1503,11 @@ public void NetworkShow(ulong clientId)
15041503 {
15051504 if ( NetworkManagerOwner . LogLevel <= LogLevel . Error )
15061505 {
1507- NetworkLog . LogError ( $ "[{ name } ] Only the authority can change visibility! ") ;
1506+ NetworkLog . LogError ( $ "[{ name } ] Only the authority can change visibility. ") ;
15081507 }
15091508 }
15101509 }
15111510
1512- //CHECK this logic
15131511 if ( Observers . Contains ( clientId ) )
15141512 {
15151513 if ( NetworkManagerOwner . DistributedAuthorityMode )
@@ -1524,7 +1522,7 @@ public void NetworkShow(ulong clientId)
15241522 {
15251523 if ( NetworkManagerOwner . LogLevel <= LogLevel . Error )
15261524 {
1527- NetworkLog . LogError ( $ "[{ name } ] Only the server can change visibility! ") ;
1525+ NetworkLog . LogError ( $ "[{ name } ] Only the server can change visibility. ") ;
15281526 return ;
15291527 }
15301528 }
@@ -1591,7 +1589,7 @@ public void NetworkHide(ulong clientId)
15911589 {
15921590 if ( NetworkManager . LogLevel <= LogLevel . Error )
15931591 {
1594- NetworkLog . LogErrorServer ( $ "[{ name } ] Attempted NetworkHide while { nameof ( NetworkObject ) } is not spawned! ") ;
1592+ NetworkLog . LogErrorServer ( $ "[{ name } ] Attempted NetworkHide while { nameof ( NetworkObject ) } is not spawned. ") ;
15951593 }
15961594 }
15971595
@@ -2588,7 +2586,7 @@ internal void InvokeBehaviourNetworkSpawn()
25882586 // This assures all NetworkVariables and RPC related tables have been initialized
25892587 // prior to invoking OnNetworkSpawn so cross NetworkBehaviour:
25902588 // - accessing of NetworkVariables will work correctly.
2591- // - invocation of RPCs will work properly (and not throw exception under certain scenarios) CHECK this comment about exceptions
2589+ // - invocation of RPCs will work properly (and not throw exception under certain scenarios)
25922590 foreach ( var childBehaviour in ChildNetworkBehaviours )
25932591 {
25942592 if ( ! childBehaviour . gameObject . activeInHierarchy )
@@ -3052,7 +3050,6 @@ public void Serialize(FastBufferWriter writer)
30523050
30533051 if ( ! writer . TryBeginWrite ( writeSize ) )
30543052 {
3055- //CHECK should we remove this exception?
30563053 throw new OverflowException ( "Could not serialize SceneObject: Out of buffer space." ) ;
30573054 }
30583055
@@ -3140,7 +3137,6 @@ public void Deserialize(FastBufferReader reader)
31403137 // Try to begin reading the remaining bytes
31413138 if ( ! reader . TryBeginRead ( readSize ) )
31423139 {
3143- //CHECK should we remove this exception too?
31443140 throw new OverflowException ( "Could not deserialize SceneObject: Reading past the end of the buffer" ) ;
31453141 }
31463142
@@ -3342,7 +3338,6 @@ internal static NetworkObject Deserialize(in SerializedObject serializedObject,
33423338 }
33433339 catch ( Exception ex )
33443340 {
3345- //CHECK exception too
33463341 Debug . LogException ( ex ) ;
33473342 }
33483343
0 commit comments