fix

This fixes the issue with invoking RPCs on other child NetworkBehaviours during OnNetworkSpawn.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -779,13 +779,22 @@ internal void NetworkPreSpawn(ref NetworkManager networkManager, NetworkObject n
             }
         }
 
+        /// <summary>
+        /// Handles the initialization of all child <see cref="NetworkBehaviour"/>s.
+        /// </summary>
         internal void InternalOnNetworkSpawn()
         {
             IsSpawned = true;
             // Initialize the NetworkVariables so they are accessible in OnNetworkSpawn;
             InitializeVariables();
             UpdateNetworkProperties();
+        }
 
+        /// <summary>
+        /// Handles invoking <see cref="OnNetworkSpawn"/>.
+        /// </summary>
+        internal void NetworkSpawn()
+        {
             try
             {
                 OnNetworkSpawn();
@@ -979,12 +988,8 @@ private bool ValidateRpcMessageMetrics(Type type)
 
             if (!__rpc_name_table.ContainsKey(type))
             {
-                __initializeRpcs();
-                if (!__rpc_name_table.ContainsKey(type))
-                {
-                    Debug.LogError($"[{nameof(TrackRpcMetricsSend)}] Rpc table does not contain an entry for {type.Name}! Failed to initialize RPCs for {type.Name}.");
-                    return false;
-                }
+                Debug.LogError($"[{nameof(TrackRpcMetricsSend)}] Rpc table does not contain an entry for {type.Name}! Failed to initialize RPCs for {type.Name}.");
+                return false;
             }
             return true;
         }

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -2556,6 +2556,8 @@ internal void InvokeBehaviourNetworkSpawn()
         {
             NetworkManager.SpawnManager.UpdateOwnershipTable(this, OwnerClientId);
 
+            // Always invoke all internal network spawn methods on each child NetworkBehaviour
+            // ** before ** invoking OnNetworkSpawn.
             foreach (var childBehaviour in ChildNetworkBehaviours)
             {
                 if (!childBehaviour.gameObject.activeInHierarchy)
@@ -2565,6 +2567,17 @@ internal void InvokeBehaviourNetworkSpawn()
                 }
                 childBehaviour.InternalOnNetworkSpawn();
             }
+
+            // Invoke OnNetworkSpawn on each child NetworkBehaviour
+            foreach (var childBehaviour in ChildNetworkBehaviours)
+            {
+                if (!childBehaviour.gameObject.activeInHierarchy)
+                {
+                    Debug.LogWarning($"{GenerateDisabledNetworkBehaviourWarning(childBehaviour)}");
+                    continue;
+                }
+                childBehaviour.NetworkSpawn();
+            }
         }
 
         internal void InvokeBehaviourNetworkPostSpawn()