refactor

Making sure we still have the NetworkManager.__rpc_name_table as that has become part of the public API.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Editor/CodeGen/RuntimeAccessModifiersILPP.cs

@@ -106,12 +106,11 @@ private void ProcessNetworkManager(TypeDefinition typeDefinition, string[] assem
                 {
                     fieldDefinition.IsPublic = true;
                 }
-#if MULTIPLAYER_TOOLS && (DEVELOPMENT_BUILD || UNITY_EDITOR || UNITY_MP_TOOLS_NET_STATS_MONITOR_ENABLED_IN_RELEASE)
+
                 if (fieldDefinition.Name == nameof(NetworkManager.__rpc_name_table))
                 {
                     fieldDefinition.IsPublic = true;
                 }
-#endif
             }
 
             foreach (var nestedTypeDefinition in typeDefinition.NestedTypes)

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -49,10 +49,8 @@ public class NetworkManager : MonoBehaviour, INetworkUpdateSystem
         // RuntimeAccessModifiersILPP will make this `public`
         internal static readonly Dictionary<uint, RpcReceiveHandler> __rpc_func_table = new Dictionary<uint, RpcReceiveHandler>();
 
-#if MULTIPLAYER_TOOLS && (DEVELOPMENT_BUILD || UNITY_EDITOR || UNITY_MP_TOOLS_NET_STATS_MONITOR_ENABLED_IN_RELEASE)
-        // RuntimeAccessModifiersILPP will make this `public`
+        // RuntimeAccessModifiersILPP will make this `public` (legacy table should be removed in v3.x.x)
         internal static readonly Dictionary<uint, string> __rpc_name_table = new Dictionary<uint, string>();
-#endif
 
 #pragma warning restore IDE1006 // restore naming rule violation check