Skip to content

Commit 49b35d2

Browse files
committed
package_pack runs faster than vetting_test or standards_check. Define it last so the other two are earlier in the VM queue
1 parent 7dc9799 commit 49b35d2

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.yamato/_run-all.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@
1515
run_quick_checks:
1616
name: Run Quick Initial Checks
1717
dependencies:
18-
- .yamato/package-pack.yml#package_pack_-_ngo_ubuntu
19-
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
2018
# Run API validation to early-detect all new APIs that would force us to release new minor version of the package. Note that for this to work the package version in package.json must correspond to "actual package state" which means that it should be higher than last released version
2119
- .yamato/vetting-test.yml#vetting_test
20+
# ensure the code is running to our current standards
21+
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
22+
# ensure the package can be packed at at all on at least one platform
23+
- .yamato/package-pack.yml#package_pack_-_ngo_win
2224

2325

2426
# Runs all package tests

.yamato/_triggers.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
pr_minimal_required_checks:
5252
name: Minimal PR checks
5353
dependencies:
54-
- .yamato/package-pack.yml#package_pack_-_ngo_win
5554
- .yamato/project-standards.yml#standards_ubuntu_testproject_trunk
55+
- .yamato/package-pack.yml#package_pack_-_ngo_win
5656
triggers:
5757
expression: |-
5858
(pull_request.comment eq "ngo" OR

.yamato/project-standards.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ standards_{{ platform.name }}_{{ project.name }}_{{ editor }}:
4646
- dotnet format --version
4747

4848
- unity-downloader-cli --fast --wait -u {{ editor }} -c editor {% if platform.name == "mac" %} --arch arm64 {% endif %} # For macOS we use ARM64 models. Downloads basic editor
49-
- dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --check # Runs standards check
5049
- .Editor/Unity -batchmode -nographics -logFile - -executeMethod Packages.Rider.Editor.RiderScriptEditor.SyncSolution -projectPath {{ project.path }} -quit # This command is used to invoke Unity in a "headless" mode. It's used to sync the project
50+
- dotnet run --project=dotnet-tools/netcode.standards -- --project={{ project.path }} --check # Runs standards check
5151
{% endfor -%}
5252
{% endfor -%}
5353
{% endfor -%}

0 commit comments

Comments
 (0)