NEW: Icon to InputSystem settings asset

[josepmariapujol-unity]

Description

Adding an icon to InputSystem settings asset InputSystem.inputsettings.

Icon library:

Dark:

Light:

Testing status & QA

N/A

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

• Complexity: 0
• Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

[u-pr]

The pull request introduces improvements to the Input System's editor settings, specifically regarding icon management. However, there are a few architectural and performance issues identified, such as setting icons in OnEnable (which can cause VCS noise) and potential icon persistence issues when creating new assets.

_{🤖 Helpful? 👍/👎}

[u-pr]

Calling EditorGUIUtility.SetIconForObject inside OnEnable of an Editor is an anti-pattern that can lead to several issues:

1. Metadata Pollution: For assets, this method modifies the associated .meta file. Calling it in OnEnable ensures the metadata is potentially modified every time the asset is selected or the inspector is refreshed, causing unnecessary noise in Version Control Systems (e.g., Git, Perforce).
2. Dirtying Assets: It may mark the asset as dirty, triggering "Save Changes" prompts or automatic saves when the user merely viewed the asset.
3. Import Loops: In some Unity versions, modifying metadata can trigger an asset re-import, which might re-trigger OnEnable, potentially leading to a refresh loop.

It is recommended to set the icon once during asset creation or via an AssetPostprocessor rather than forcing it every time the inspector is enabled.

_{🤖 Helpful? 👍/👎}

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...putSystem/Editor/Settings/InputSettingsProvider.cs	0.00%	10 Missing ⚠️
...Editor/AssetImporter/InputActionAssetIconLoader.cs	0.00%	3 Missing ⚠️

@@            Coverage Diff            @@
##           develop    #2400    +/-   ##
=========================================
  Coverage    78.13%   78.13%            
=========================================
  Files          483      483            
  Lines        98770    98662   -108     
=========================================
- Hits         77169    77089    -80     
+ Misses       21601    21573    -28     

Files with missing lines	Coverage Δ
...Editor/AssetImporter/InputActionAssetIconLoader.cs	66.66% <0.00%> (-33.34%)	⬇️
...putSystem/Editor/Settings/InputSettingsProvider.cs	1.34% <0.00%> (-0.28%)	⬇️

... and 94 files with indirect coverage changes

ℹ️ Need help interpreting these results?

[Pauliusd01]

FYI: I don't have capacity to test this yet, have 2 large PRs that need to be sorted first. Expecting to come back to this next week