CHANGE: Update asset InputSystem.inputsettings to use UI Toolkit framework#2393
CHANGE: Update asset InputSystem.inputsettings to use UI Toolkit framework#2393josepmariapujol-unity wants to merge 17 commits intodevelopfrom
Conversation
Explicitly update the SerializedObject in InputActionImporterEditor.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2393 +/- ##
===========================================
+ Coverage 78.13% 78.70% +0.57%
===========================================
Files 483 755 +272
Lines 98770 137539 +38769
===========================================
+ Hits 77169 108252 +31083
- Misses 21601 29287 +7686 Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test_plan |
Test Plan
Summary of Changes & Risk AssessmentSummary of ChangesThis PR migrates the inspector UI for Risk Assessment
Test ScenariosFunctional Testing
Regression Testing
Edge Cases
💡 This test plan updates automatically when 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
|
Text can go outside the button when scaled |
Pauliusd01
left a comment
There was a problem hiding this comment.
Text/button isn't updated correctly when multiple inspectors are used
https://github.com/user-attachments/assets/a9e54976-0525-4cd6-9094-c3b6c8fcc030
There was a problem hiding this comment.
This PR migrates the InputSettings inspector to UI Toolkit. While the refactoring is mostly solid, there are several important issues that should be addressed:
- Compatibility: The use of the
HelpBoxVisualElement may break compatibility with Unity versions older than 2021.1. - UI State/Sync: The new UI Toolkit implementation introduces a regression where the UI can become stale if settings are changed externally (e.g., via Project Settings or Undo), unlike the previous IMGUI implementation which polled every frame.
- Polishing: Several minor issues regarding string formatting (double spaces), unused parameters, and inconsistent spelling were identified.
Please see the inline comments for specific details and suggested improvements.
🤖 Helpful? 👍/👎
|
Will review review the PR again after the AI suggestions |
K-Tone
left a comment
There was a problem hiding this comment.
Looks good to me, but can we get an answer to the UPR comment?
|
What is the URP comment? @K-Tone |
|
@u-pr have all comments been addressed here thus far? |
|
While several critical issues (like UI staleness and version compatibility) have been resolved, there are still a few minor feedback points and one reported regression that appear unaddressed based on the latest changes: Unaddressed Items
Resolved Items
🤖 Helpful? 👍/👎 |
|
Sadly, I don't precisely remember what that UPR comment was before, all comments look closed to me at the time I'm writing here. However, can you check about the UPR judgement just above my comment? The one that lists the AI concerns on the PR, see if anything from there makes any sense. I'd be fine approving it right afterwards. Thanks. |
|
Fixed: UI Regression (Text Scaling): The issue reported by @Pauliusd01 regarding text going outside the button likely persists for the "Assign as the settings" button. While the "Open" button was fixed in InputSettingsEditor.cs (line 499), the "Assign" button in InputAssetEditorUtils.cs (line 125) still lacks whiteSpace = WhiteSpace.Normal and a minHeight.
Also, Fixed: Spelling Inconsistency: The summary on line 23 still uses "canceled" (American English), while the enum member Cancelled on line 25 uses British English. For consistency with the rest of the codebase, "cancelled" is generally preferred. |

Description
This PR is updating the UI for asset
InputSystem.inputsettingsto use UI Toolkit framework.Before:

After:

Testing status & QA
Once you create an input settings check the asset and click the button, see video.
Screen.Recording.2026-03-23.at.12.58.07.mov
Page refresh test:
assigne.mov
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.