Open
Conversation
…th-selection # Conflicts: # buildSrc/src/main/kotlin/Versions.kt # usvm-core/src/main/kotlin/org/usvm/Machine.kt # usvm-core/src/main/kotlin/org/usvm/ps/PathSelectorFactory.kt # usvm-jvm/build.gradle.kts
# Conflicts: # usvm-core/build.gradle.kts
Saloed
requested changes
Sep 12, 2023
usvm-ml-path-selection/src/main/kotlin/org/usvm/ModifiedUMachineOptions.kt
Show resolved
Hide resolved
| class CoverageCounterStatistics<State : UState<*, *, *, *, State>>( | ||
| private val coverageStatistics: CoverageStatistics<*, *, State>, | ||
| private val coverageCounter: CoverageCounter, | ||
| private val methodName: String |
Collaborator
There was a problem hiding this comment.
Do we include method signature here?
usvm-ml-path-selection/src/main/kotlin/org/usvm/ps/BlockGraph.kt
Outdated
Show resolved
Hide resolved
usvm-ml-path-selection/src/main/kotlin/org/usvm/util/ModifiedUtil.kt
Outdated
Show resolved
Hide resolved
usvm-ml-path-selection/src/main/kotlin/org/usvm/CoverageCounter.kt
Outdated
Show resolved
Hide resolved
Saloed
reviewed
Sep 12, 2023
usvm-ml-path-selection/src/main/kotlin/org/usvm/machine/ModifiedJcMachine.kt
Outdated
Show resolved
Hide resolved
Closed
Closed
Saloed
reviewed
Oct 20, 2023
usvm-ml-path-selection/src/main/kotlin/org/usvm/ps/FeaturesLogger.kt
Outdated
Show resolved
Hide resolved
Saloed
reviewed
Oct 20, 2023
| testStatementsCounts.values.sum(), | ||
| testFinished.values.sumOf { if (it) 1.0 else 0.0 }.toFloat(), | ||
| ) | ||
| return Json.encodeToJsonElement(statistics).jsonObject |
Collaborator
There was a problem hiding this comment.
It is better to return a statistics object, avoiding serialization to json.
Saloed
reviewed
Oct 20, 2023
| if (path.isEmpty()) { | ||
| return | ||
| } | ||
| val jsonData = buildJsonObject { |
Collaborator
There was a problem hiding this comment.
It is better to use serializable object instead of creating a json manually.
Collaborator
Author
There was a problem hiding this comment.
The first field of this object would need to be a multidimensional array of floats of unknown depth. I can think of 2 ways of making it serializabe: writing a custom serializer or making it a JsonArray. Both options seem to me like doing almost the same thing as creating a json manually, but probably even worse.
Saloed
reviewed
Nov 8, 2023
| return blockList.map { getBlockFeatures(it) } | ||
| } | ||
|
|
||
| fun saveGraph(filePath: Path) { |
Collaborator
There was a problem hiding this comment.
It is better to split the BlockGraph data structure and graph printer
| env, edgesDataBuffer, | ||
| edgesShape.map { it.toLong() }.toLongArray() | ||
| ) | ||
| val result = gnnSession!!.run(mapOf(Pair("x", featuresData), Pair("edge_index", edgesData))) |
| ) | ||
| val result = gnnSession!!.run(mapOf(Pair("x", featuresData), Pair("edge_index", edgesData))) | ||
| val output = (result.get("output").get().value as Array<*>).map { | ||
| (it as FloatArray).toList() |
Collaborator
There was a problem hiding this comment.
It is better to use FloatArray if possible
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Sep 22, 2025
* fix: lint * fix: inherit test method annotations from fakeMethod * feat: introduce reflection utils renderer, remove spring import manager * Fix class expression render for primitive and array types (UnitTestBot#144) * Fix empty unbound wildcard type bound (UnitTestBot#147) * feat: introduce reflection utils inline strategy Signed-off-by: Andrew Petrukhin <dartmol2300@gmail.com> * refactor: update reflection utils inline strategy ownership * fix: update JcSpringMvcTestTransformer.kt to match actual context init * fix: style * feat: remove unsafe import manager * fix: pass isAccessibleFromTestClass separately from inline strategy * fix: remove file renderer from unsafe utils renderer * fix: style --------- Signed-off-by: Andrew Petrukhin <dartmol2300@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.