Make Spring-specific no NPE speculation to only trigger for mocks#2572
Closed
IlyaMuravjov wants to merge 1 commit intomainfrom
Closed
Make Spring-specific no NPE speculation to only trigger for mocks#2572IlyaMuravjov wants to merge 1 commit intomainfrom
IlyaMuravjov wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
On second thought we can't rely solely on the fact that engine decided to mock or not to mock some fields, since fuzzer may do mocking differently, so I think we should do some execution filtering after the generation has completed. |
7f7a168 to
1d1864d
Compare
Collaborator
Author
|
Replaced with #2617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Spring-specific unit tests class under test field can't be mocks in one execution and null in another due to
@InjectMockeither always injecting or non injecting the mocks into class under test.How to test
Manual tests
spring-boot-testingproject.Mock everything outside the classstrategy for the following classes.There should be NPE tests for
equals()in the following class:There should be no NPE tests for
createOrder()in the following classSelf-check list