Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
echo "store=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Restore pnpm cache
uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
with:
path: ${{ steps.pnpm-cache.outputs.store }}
key: ${{ runner.os }}-pnpm-store-cache-
Expand Down Expand Up @@ -124,38 +124,38 @@ jobs:
retention-days: 1
if: ${{ github.event_name == 'pull_request' }}

dangerbot:
runs-on: ubuntu-latest
if: github.repository == 'DefinitelyTyped/DefinitelyTyped' && github.event_name == 'pull_request'

needs:
- test

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: ./.github/actions/setup-for-scripts

- name: Get suggestions dir
id: suggestions-dir
run: echo "path=$(node ./scripts/get-suggestions-dir.js)" >> "$GITHUB_OUTPUT"

- uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
path: ${{ steps.suggestions-dir.outputs.path }}
merge-multiple: true

- name: 'Run Danger'
env:
# See https://github.com/danger/danger-js/issues/1042
DANGER_GITHUB_API_BASE_URL: 'https://api.github.com'

# Danger failing (for example through rate-limiting) shouldn't fail the build
run: |
# Exposing this token is safe because the user of it has no other public repositories
# and has no permission to modify this repository. See #62638 for the discussion.
TOKEN='ghp_i5wtj1l2AbpFv3OU96w6R'
TOKEN+='On3bHOkcV2AmVY6'
DANGER_GITHUB_API_TOKEN=$TOKEN pnpm danger ci || $( exit 0 )
# dangerbot:
# runs-on: ubuntu-latest
# if: github.repository == 'DefinitelyTyped/DefinitelyTyped' && github.event_name == 'pull_request'

# needs:
# - test

# steps:
# - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# - uses: ./.github/actions/setup-for-scripts

# - name: Get suggestions dir
# id: suggestions-dir
# run: echo "path=$(node ./scripts/get-suggestions-dir.js)" >> "$GITHUB_OUTPUT"

# - uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
# with:
# path: ${{ steps.suggestions-dir.outputs.path }}
# merge-multiple: true

# - name: 'Run Danger'
# env:
# # See https://github.com/danger/danger-js/issues/1042
# DANGER_GITHUB_API_BASE_URL: 'https://api.github.com'

# # Danger failing (for example through rate-limiting) shouldn't fail the build
# run: |
# # Exposing this token is safe because the user of it has no other public repositories
# # and has no permission to modify this repository. See #62638 for the discussion.
# TOKEN='ghp_i5wtj1l2AbpFv3OU96w6R'
# TOKEN+='On3bHOkcV2AmVY6'
# DANGER_GITHUB_API_TOKEN=$TOKEN pnpm danger ci || $( exit 0 )

scripts:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format-and-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
id: date
run: echo "date=$(/bin/date -u "+%Y-%m-%d")" >> $GITHUB_OUTPUT

- uses: actions/cache@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
- uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
with:
# dprint caches info about the files in the repo to skip formatting them.
# However, since package.json and .dprint.jsonc don't change very often,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pnpm-cache.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
run: pnpm install

- name: Save pnpm cache
uses: actions/cache/save@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
with:
path: ${{ steps.pnpm-cache.outputs.store }}
key: ${{ runner.os }}-pnpm-store-cache-${{ steps.pnpm-cache.outputs.date }}
7 changes: 1 addition & 6 deletions types/ng-notify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,5 @@
"devDependencies": {
"@types/ng-notify": "workspace:."
},
"owners": [
{
"name": "Nick Zamosenchuk",
"githubUsername": "nzamosenchuk"
}
]
"owners": []
}
9 changes: 7 additions & 2 deletions types/office-js-preview/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40142,6 +40142,7 @@ declare namespace Excel {
readonly calculationEngineVersion: number;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -40815,13 +40816,12 @@ declare namespace Excel {
* Inserts the specified worksheets from a source workbook into the current workbook.

The `extensionHardening` Windows registry key affects this API. The file extension defined by the `base64File` param must match the real file type of the inserted file. If `extensionHardening` is set to deny mismatches and the file extension does not match the real file type, this API throws the following error: "This operation is not allowed due to the extension hardening policy."

**Note**: This API is currently only supported for Office on Windows, Mac, and the web.
*
* @remarks
* [Api set: ExcelApi 1.13]
*
* This API is currently only supported for Office on Windows, Mac, and the web.
* In Excel on the web, this API doesn't support inserting charts, comments, PivotTables, or slicers.
*
* @param base64File Required. The Base64-encoded string representing the source workbook file.
* @param options Optional. The options that define which worksheets to insert and where in the workbook the new worksheets will be inserted. By default, all the worksheets from the source workbook are inserted at the end of the current workbook.
Expand Down Expand Up @@ -41289,6 +41289,7 @@ declare namespace Excel {
evaluate(name: string): OfficeExtension.ClientResult<any>;
/**
* Finds all occurrences of the given string based on the criteria specified and returns them as a `RangeAreas` object, comprising one or more rectangular ranges.
* Content in hidden worksheets is not returned.
*
* @remarks
* [Api set: ExcelApi 1.9]
Expand All @@ -41300,6 +41301,7 @@ declare namespace Excel {
findAll(text: string, criteria: Excel.WorksheetSearchCriteria): Excel.RangeAreas;
/**
* Finds all occurrences of the given string based on the criteria specified and returns them as a `RangeAreas` object, comprising one or more rectangular ranges.
* Content in hidden worksheets is not returned.
*
* @remarks
* [Api set: ExcelApi 1.9]
Expand Down Expand Up @@ -74574,6 +74576,7 @@ declare namespace Excel {
iterativeCalculation?: Excel.Interfaces.IterativeCalculationUpdateData;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -80452,6 +80455,7 @@ declare namespace Excel {
calculationEngineVersion?: number;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -88620,6 +88624,7 @@ declare namespace Excel {
calculationEngineVersion?: boolean;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down
9 changes: 7 additions & 2 deletions types/office-js/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35796,6 +35796,7 @@ declare namespace Excel {
readonly calculationEngineVersion: number;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -36349,13 +36350,12 @@ declare namespace Excel {
* Inserts the specified worksheets from a source workbook into the current workbook.

The `extensionHardening` Windows registry key affects this API. The file extension defined by the `base64File` param must match the real file type of the inserted file. If `extensionHardening` is set to deny mismatches and the file extension does not match the real file type, this API throws the following error: "This operation is not allowed due to the extension hardening policy."

**Note**: This API is currently only supported for Office on Windows, Mac, and the web.
*
* @remarks
* [Api set: ExcelApi 1.13]
*
* This API is currently only supported for Office on Windows, Mac, and the web.
* In Excel on the web, this API doesn't support inserting charts, comments, PivotTables, or slicers.
*
* @param base64File Required. The Base64-encoded string representing the source workbook file.
* @param options Optional. The options that define which worksheets to insert and where in the workbook the new worksheets will be inserted. By default, all the worksheets from the source workbook are inserted at the end of the current workbook.
Expand Down Expand Up @@ -36815,6 +36815,7 @@ declare namespace Excel {
evaluate(name: string): OfficeExtension.ClientResult<any>;
/**
* Finds all occurrences of the given string based on the criteria specified and returns them as a `RangeAreas` object, comprising one or more rectangular ranges.
* Content in hidden worksheets is not returned.
*
* @remarks
* [Api set: ExcelApi 1.9]
Expand All @@ -36826,6 +36827,7 @@ declare namespace Excel {
findAll(text: string, criteria: Excel.WorksheetSearchCriteria): Excel.RangeAreas;
/**
* Finds all occurrences of the given string based on the criteria specified and returns them as a `RangeAreas` object, comprising one or more rectangular ranges.
* Content in hidden worksheets is not returned.
*
* @remarks
* [Api set: ExcelApi 1.9]
Expand Down Expand Up @@ -69455,6 +69457,7 @@ declare namespace Excel {
iterativeCalculation?: Excel.Interfaces.IterativeCalculationUpdateData;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -74992,6 +74995,7 @@ declare namespace Excel {
calculationEngineVersion?: number;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down Expand Up @@ -82545,6 +82549,7 @@ declare namespace Excel {
calculationEngineVersion?: boolean;
/**
* Returns the calculation mode used in the workbook, as defined by the constants in `Excel.CalculationMode`. Possible values are: `Automatic`, where Excel controls recalculation; `AutomaticExceptTables`, where Excel controls recalculation but ignores changes in tables; `Manual`, where calculation is done when the user requests it.
* This is a runtime property. The `calculationMode` setting is not persisted in the workbook.
*
* @remarks
* [Api set: ExcelApi 1.1 for get, 1.8 for set]
Expand Down