Skip to content

fix: template selection blocked when product uses default (allow all) mode #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
Apr 7, 2026
+14 −2
Merged

fix: template selection blocked when product uses default (allow all) mode #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions inc/limitations/class-limit-site-templates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ public function get_all_templates(): array {
*/
public function get_available_site_templates() {

/*
* MODE_DEFAULT means "allow all templates" — no restriction.
* Return false so callers that check is_array() treat this as unrestricted.
*/
if (self::MODE_DEFAULT === $this->mode) {
return false;
}

$limits = $this->get_limit();

if ( ! $limits) {
Expand All @@ -219,8 +227,7 @@ public function get_available_site_templates() {
$site_settings = (object) $site_settings;

if (self::BEHAVIOR_AVAILABLE === $site_settings->behavior ||
self::BEHAVIOR_PRE_SELECTED === $site_settings->behavior ||
self::MODE_DEFAULT === $this->mode) {
self::BEHAVIOR_PRE_SELECTED === $site_settings->behavior) {
// Convert to integer to match type used in validation (absint)
$available[] = absint($site_id);
}
Expand Down
5 changes: 5 additions & 0 deletions inc/limits/class-site-template-limits.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ protected function is_template_available( $products, $template_id ) {
} else {
$available_templates = $limits->site_templates->get_available_site_templates();

// false means no restriction (MODE_DEFAULT) — all templates are available.
if ( false === $available_templates ) {
return true;
}

return in_array( $template_id, $available_templates, true );
}
}
Expand Down
Loading