-
Notifications
You must be signed in to change notification settings - Fork 30
add deeprag tool #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deeprag tool #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good,
we can merge it after prereq PR's are in
we need to also bump the version
| "type": "string", | ||
| "description": query_setting.description | ||
| if query_setting and query_setting.description | ||
| else "The query to create a deeprag off of", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably improve this description
7e99040 to
d62b4a5
Compare
| output_schema=output_model.model_json_schema(), | ||
| example_calls=[], # Examples cannot be provided for internal tools | ||
| ) | ||
| async def batch_transform_tool_fn(**kwargs: Any) -> dict[str, Any]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the args not be typed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with typing the args is that then I would have to duplicate the function. 1 for static which doesn't expect a query and 1 for dynamic which needs a query. which I could do idc
old comment requesting that dependencies are merged first. which was done.
bea930e to
85a6917
Compare
03e7d4a to
4cb0a49
Compare
No description provided.