Skip to content

Conversation

@CalebMartinUiPath
Copy link
Contributor

No description provided.

Copy link
Collaborator

@radu-mocanu radu-mocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
we can merge it after prereq PR's are in

we need to also bump the version

"type": "string",
"description": query_setting.description
if query_setting and query_setting.description
else "The query to create a deeprag off of",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably improve this description

@CalebMartinUiPath CalebMartinUiPath force-pushed the caleb/add-ecs-tools branch 2 times, most recently from 7e99040 to d62b4a5 Compare January 27, 2026 23:50
@CalebMartinUiPath CalebMartinUiPath marked this pull request as ready for review January 29, 2026 08:07
output_schema=output_model.model_json_schema(),
example_calls=[], # Examples cannot be provided for internal tools
)
async def batch_transform_tool_fn(**kwargs: Any) -> dict[str, Any]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the args not be typed?

Copy link
Contributor Author

@CalebMartinUiPath CalebMartinUiPath Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with typing the args is that then I would have to duplicate the function. 1 for static which doesn't expect a query and 1 for dynamic which needs a query. which I could do idc

@CalebMartinUiPath CalebMartinUiPath dismissed radu-mocanu’s stale review February 3, 2026 19:33

old comment requesting that dependencies are merged first. which was done.

@CalebMartinUiPath CalebMartinUiPath merged commit f123d58 into main Feb 3, 2026
39 checks passed
@CalebMartinUiPath CalebMartinUiPath deleted the caleb/add-ecs-tools branch February 3, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants