add zonal_anomaly with shared face-band weight kernel#1508
Open
rajeeja wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new UxDataArray.zonal_anomaly() API to compute per-face zonal anomalies (subtracting each face’s latitude-band mean) and refactors conservative zonal-mean geometry into a shared face–band overlap kernel.
Changes:
- Added
UxDataArray.zonal_anomaly()public method to return an anomaly field on the original unstructured grid. - Introduced
_compute_face_band_weights()to share conservative face–latitude-band overlap calculations. - Refactored conservative zonal-mean implementation to use the shared weight kernel.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
uxarray/core/zonal.py |
Adds shared face–band weight computation and implements zonal anomaly backend logic. |
uxarray/core/dataarray.py |
Exposes zonal_anomaly() as a new UxDataArray method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erogluorhan
reviewed
May 22, 2026
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
This is looking great; it only lacks documentation (user guide addition) I think
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rajeeja
force-pushed
the
rajeeja/fix-zonal-anomaly
branch
from
f748225 to
61e61a8
Compare
rajeeja
force-pushed
the
rajeeja/fix-zonal-anomaly
branch
from
61e61a8 to
815889c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
UxDataArray.zonal_anomaly()returning a same-dimension array where each face value has its latitude-band mean subtracted.To avoid duplicating the expensive geometric intersection work already done by
zonal_mean, the face-band overlap areas are extracted into a shared kernel_compute_face_band_weights(uxgrid, bands)that bothzonal_meanandzonal_anomalycall. The conservative path blends band means across straddling faces using the same weight matrix; the default (non-conservative) path assigns each face to a band by centroid latitude.Fixes #1247