fix(ui5-list): guard item-toggle against null event detail#13646
Open
plamenivanov91 wants to merge 1 commit into
Open
fix(ui5-list): guard item-toggle against null event detail#13646plamenivanov91 wants to merge 1 commit into
plamenivanov91 wants to merge 1 commit into
Conversation
Prevent runtime crashes when a bubbling ui5-toggle event reaches ui5-list with null detail (for example from nested components such as ui5-panel). Update List.onItemToggle to safely read e.detail?.item and return early when no item is provided before firing ui5-item-toggle. Add Cypress regression coverage in List.cy.tsx for null-detail toggle events and keep the nested panel scenario check. Fixes: #13576
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13646--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent runtime crashes when a bubbling ui5-toggle event reaches ui5-list with null detail (for example from nested components such as ui5-panel).
Update List.onItemToggle to safely read e.detail?.item and return early when no item is provided before firing ui5-item-toggle.
Add Cypress regression coverage in List.cy.tsx for null-detail toggle events and keep the nested panel scenario check.
Fixes: #13576