fix(ui5-form): correct layout breakpoints near L/XL boundary#13522
Open
ilhan007 wants to merge 1 commit into
Open
fix(ui5-form): correct layout breakpoints near L/XL boundary#13522ilhan007 wants to merge 1 commit into
ilhan007 wants to merge 1 commit into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13522--ui5-webcomponents-preview.netlify.app |
The container query breakpoints in both static CSS and dynamic CSS did not match the spec (S: 0-599, M: 600-1023, L: 1024-1439, XL: 1440+), causing a gap at 1439-1440px where the layout fell back incorrectly. Fixes #13420
ilhan007
force-pushed
the
fix/form-layout-breakpoints
branch
from
c51fa6b to
b15fa35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The spec defines these breakpoints:
Both the static CSS (
FormLayout.css,FormItemSpan.css) and dynamically generated CSS (Form.ts) were off by 1px at multiple boundaries. This was most noticeable at the L→XL transition when usingL4 XL4layout, where the dynamic column rule didn't apply at 1439–1440px.Files changed
packages/main/src/Form.ts— dynamic container queries + JSDocpackages/main/src/themes/FormLayout.css— static container queriespackages/main/src/themes/FormItemSpan.css— static container queriesTest plan
layout="S1 M2 L4 XL4"shows 4 columns consistently across L and XL boundaryFixes #13420