fix(ui5-button): update aria-label when accessibleNameRef target changes#13104
Open
fix(ui5-button): update aria-label when accessibleNameRef target changes#13104
Conversation
Button now observes changes to elements referenced via accessibleNameRef and updates its aria-label accordingly. Previously, the aria-label would only update when the Button re-rendered for other reasons. The fix registers the Button with AccessibilityTextsHelper to observe mutations on referenced elements, matching the behavior of Input and other components. Fixes #13101
Collaborator
|
🚀 Deployed on https://pr-13104--ui5-webcomponents-preview.netlify.app |
Only cache accessibleNameRef texts (which require DOM lookups and mutation observation). Use accessibleName property directly in the getter, matching the pattern used by Input component. This fixes the issue where dynamically setting accessibleName (e.g., from Panel's useAccessibleNameForToggleButton) wasn't reflected because the cached value wasn't updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessibleNameRefand updates itsaria-labelaccordinglyaria-labelwould only update when the Button re-rendered for other reasons (e.g., being clicked)AccessibilityTextsHelperto observe mutations on referenced elements, matching the behavior of Input and other componentsTest plan
AccessibilityTextsHelper.cy.tsxthat verifies multiple buttons referencing the same label all update when the label's text changesFixes #13101
🤖 Analyzed, fixed and PR created by Claude Code