feat(ui5-color-palette-popover): add placement property #12993
+85
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12993--ui5-webcomponents-preview.netlify.app |
tsanislavgatev
requested changes
Feb 3, 2026
| ); | ||
| } | ||
|
|
||
| describe("Color Popover Palette general interaction tests", () => { |
Contributor
There was a problem hiding this comment.
Why do we change the formatting of all of these tests?
Contributor
Author
There was a problem hiding this comment.
The tests were not tabulated by TAB but by SPACEs, but you're right, it is matter of another PR, I'll publish just my changes here.
| /** | ||
| * Determines on which side the component is placed at. | ||
| * @default "Bottom" | ||
| * @public |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new property
placementof the<ui5-color-palette-popover>, which accepts values fromPopoverPlacementenum (the same used by the<ui5-popover>and<ui5-responsive-popover>. Possible values are Top, Bottom, Start and End, and the default value of the property is Bottom.The value of this property is passed directly to the internal
<ui5-responsive-popover>in order to display the color palette popover at desired position based to the opener.JIRA: BGSOFUIBALKAN-9994