feat(ui5-tokenizer/ui5-multi-input/ui5-multi-combobox): align mobile popover title with spec #12979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popover title with spec
Collaborator
|
🚀 Deployed on https://pr-12979--ui5-webcomponents-preview.netlify.app |
ndeshev
reviewed
Feb 2, 2026
| onTokenDelete={this.tokenDelete} | ||
| onFocusOut={this._tokenizerFocusOut} | ||
| onShowMoreItemsPress={this._showMoreItemsPress} | ||
| accessibleName={this.accessibleName} |
Contributor
There was a problem hiding this comment.
We shouldn't change the Tokenizer's title with the MultiInput's label. We should only do it in the standalone Tokenizer.
For example, let say we have a MultiInput with a label "Enter your favorite movies in this MultiInput". We don't want that to be the Tokenizer's title, as in that dialog you can only see or/and delete tokens.
| @@ -2190,7 +2190,7 @@ class MultiComboBox extends UI5Element implements IFormInputElement { | |||
| } | |||
|
|
|||
| get _headerTitleText() { | |||
Contributor
There was a problem hiding this comment.
Does the specification for the input suggestions specify that? Because the backlog item is only for the tokenizer's dialog title. If the same should be done for the suggestions dialog - ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRILA-4218