Skip to content

fix(ui5-dynamic-date-range): add accessibleName to the ResponsivePopover #12965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hinzzx merged 1 commit into from
Feb 4, 2026
Merged

fix(ui5-dynamic-date-range): add accessibleName to the ResponsivePopover #12965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/main/src/DynamicDateRange.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
DYNAMIC_DATE_RANGE_SELECTED_TEXT,
DYNAMIC_DATE_RANGE_EMPTY_SELECTED_TEXT,
DYNAMIC_DATE_RANGE_NAVIGATION_ICON_TOOLTIP,
DYNAMIC_DATE_RANGE_POPOVER_ACCESSIBLE_NAME,
} from "./generated/i18n/i18n-defaults.js";

// default calendar for bundling
Expand Down Expand Up @@ -288,6 +289,10 @@ class DynamicDateRange extends UI5Element {
return DynamicDateRange.i18nBundle.getText(DYNAMIC_DATE_RANGE_NAVIGATION_ICON_TOOLTIP);
}

get popoverAccessibleName() {
return DynamicDateRange.i18nBundle.getText(DYNAMIC_DATE_RANGE_POPOVER_ACCESSIBLE_NAME);
}

_togglePicker(): void {
if (this.open) {
this._close();
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/DynamicDateRangePopoverTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default function DynamicDateRangePopoverTemplate(this: DynamicDateRange)
onClose={this.onPopoverClose}
onBeforeOpen={this.onPopoverBeforeOpen}
onKeyDown={this.onKeyDownPopover}
accessibleName={this.popoverAccessibleName}
>
{this._hasCurrentOptionTemplate &&
<div slot="header" class="ui5-ddr-header">
Expand Down
3 changes: 3 additions & 0 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,9 @@ DYNAMIC_DATE_TIME_RANGE_TEXT_FROM_LABEL=From
#FLD: Text for the selected date section when there's no value in the DynamicDateRange component.
DYNAMIC_DATE_RANGE_EMPTY_SELECTED_TEXT=Choose Dates

#XACT: Accessible name for the DynamicDateRange popover dialog.
DYNAMIC_DATE_RANGE_POPOVER_ACCESSIBLE_NAME=Dynamic Date Range

#XFLD: Text for icon that navigates back to the previous page in the DynamicDateRange component.
DYNAMIC_DATE_RANGE_NAVIGATION_ICON_TOOLTIP=Navigate back

Expand Down
Loading