feat(dts-generator): add bindList declarations and tests to TypedJSONModel #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d tests to TypedJSONModel This reverts commit ae4ba2e.
pksinsik
reviewed
Jan 29, 2026
PeterBuchholz
suggested changes
Jan 30, 2026
pksinsik
reviewed
Feb 2, 2026
test-packages/typed-json-model/webapp/model/test/cases/absolute-complex-inference.ts
Outdated
Show resolved
Hide resolved
test-packages/typed-json-model/webapp/model/test/cases/relative-complex-inference.ts
Outdated
Show resolved
Hide resolved
PeterBuchholz
approved these changes
Feb 2, 2026
pksinsik
approved these changes
Feb 2, 2026
viktorsperling
requested review from
codeworrior
and removed request for
1110101
Collaborator
Author
|
As this is part of a greater feature, we are not merging this PR yet. This will be done as soon as the rest of the APIs in the feature are implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary typing for the
bindListAPI of the JSONModel, to the TypedJSONModel.