Kent branch Add more functionality on right click popup menu#22
Open
kent0318 wants to merge 5 commits intodevelop_smarttoolfrom
Open
Kent branch Add more functionality on right click popup menu#22kent0318 wants to merge 5 commits intodevelop_smarttoolfrom
kent0318 wants to merge 5 commits intodevelop_smarttoolfrom
Conversation
…into KentBranch
…into KentBranch
UltimatePea
reviewed
Mar 16, 2017
| // TODO Auto-generated method stub | ||
| return ActionsMenuBarTitles.Data().Remove().toString(); } | ||
|
|
||
| if(panel.getSelectTool() instanceof SmartTool) |
Member
There was a problem hiding this comment.
This approach (using instanceof) is dangerous, Please Comment on these two lines on the reason for selection.
Instanceof makes code unmaintanable.
Member
There was a problem hiding this comment.
Please make a comment on the approach taken,
Include the following line:
//TODO RECONSIDER THIS DESIGN
UltimatePea
requested changes
Mar 16, 2017
Member
UltimatePea
left a comment
UltimatePea
left a comment
There was a problem hiding this comment.
Reconsider the design.
There are two broad categories of paint actions, the menu ones and the non-menu ones. I suggest make 4 methods in the PaintAction abstract class.
public boolean isMenuAction();
public boolean isPopupAction();
public String getLocationStringForMenu();
public String getLocationStringForPopup();
An action may be both, either or neither of the above mentioned actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.