Skip to content

Fix Wavedrom in Jupyter Notebook#484

Open
ryoon wants to merge 3 commits into
UCSBarchlab:developmentfrom
ryoon:fix-wavedrom-in-jupyter
Open

Fix Wavedrom in Jupyter Notebook#484
ryoon wants to merge 3 commits into
UCSBarchlab:developmentfrom
ryoon:fix-wavedrom-in-jupyter

Conversation

@ryoon

@ryoon ryoon commented Jun 5, 2026

Copy link
Copy Markdown
Contributor
  • Use HTML tags instead of jQuery.
    Tested with Jupyter Notebook 7.5.4.

There may be better solution, anyway please fix the error without jQuery.

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.0%. Comparing base (d116f66) to head (5e01e97).
⚠️ Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
pyrtl/simulation.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           development    #484     +/-   ##
=============================================
+ Coverage         91.9%   92.0%   +0.1%     
=============================================
  Files               30      30             
  Lines             7443    7439      -4     
=============================================
  Hits              6837    6837             
+ Misses             606     602      -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fdxmw

fdxmw commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thank you for fixing this! I tested this out and it works on my computer. I also added a small change that seems to fix a longstanding issue where traces don't render the first time a render_trace() cell executes.

Please let me know if the additional change looks good to you, and then I'll merge this pull request.

Edits: I updated the fix so it periodically checks if WaveDrom is loaded before calling ProcessAll(). I now see traces immediately when I load a Jupyter notebook and select Run > Run All Cells. Also, I'd like you to take a look at this change, if you have time, because I don't know anything about JavaScript :)

`WaveDrom.ProcessAll()`, rather than calling it `onload`. This fixes an issue
where traces may not render when first executing a `render_trace()` cell,
because it races with loading the JavaScript libraries.
@fdxmw fdxmw force-pushed the fix-wavedrom-in-jupyter branch from 9b76441 to 5e01e97 Compare June 11, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants