Fix Wavedrom in Jupyter Notebook#484
Conversation
* Use HTML tags instead of jQuery.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #484 +/- ##
=============================================
+ Coverage 91.9% 92.0% +0.1%
=============================================
Files 30 30
Lines 7443 7439 -4
=============================================
Hits 6837 6837
+ Misses 606 602 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for fixing this! I tested this out and it works on my computer. I also added a small change that seems to fix a longstanding issue where traces don't render the first time a Please let me know if the additional change looks good to you, and then I'll merge this pull request. Edits: I updated the fix so it periodically checks if WaveDrom is loaded before calling |
`WaveDrom.ProcessAll()`, rather than calling it `onload`. This fixes an issue where traces may not render when first executing a `render_trace()` cell, because it races with loading the JavaScript libraries.
9b76441 to
5e01e97
Compare
Tested with Jupyter Notebook 7.5.4.
There may be better solution, anyway please fix the error without jQuery.