fix: Make quote blocks isolating #2285
Open
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@nperez0111 maybe we want to make all non-paragraph blocks isolating? This seems to be closer to what Notion does. |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Contributor
|
@matthewlipski is isolating what we are looking for here or defining? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes quote blocks isolating. That means when pasting content into an empty quote block, it won't overwrite the block type to that of the clipboard content.
Closes #2236
Rationale
There is a scenario where the user wants to paste some text for a quote, so they create a new quote block using the slash menu. They then paste the quoted text into the newly created block, and the type changes to something else. This is not great for UX.
Changes
isolatingflag to quote block.Impact
N/A
Testing
We already have tests for pasting in custom blocks which are isolating.
Screenshots/Video
N/A
Checklist
Additional Notes