zip-create: remove images in zip path#614
Closed
celestecote21 wants to merge 1 commit intoTryGhost:mainfrom
Closed
zip-create: remove images in zip path#614celestecote21 wants to merge 1 commit intoTryGhost:mainfrom
images in zip path#614celestecote21 wants to merge 1 commit intoTryGhost:mainfrom
Conversation
The tool must not alter file paths between the local directory and what will be served by the Ghost instance. On the "Copy the directory" task, an `/images` is added to the destination temporary path. This addition changes the path of files that is preserved by the zipping process. This results in an incorrect path on the Ghost instance once uploaded, as the import process preserves paths.
Member
|
Hi @celestecote21, thanks for the PR! The folder being appended like that is correct, as that's what defines the unzipped folder name, which Ghost depends on in the import process. With the proposed change, if I had a large folder called I agree that the hard-coded folder name is not ideal, but this is unfortunately not the correct fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool must not alter file paths between the local directory and what will be served by the Ghost instance.
On the "Copy the directory" task, an
/imagesis added to the destination temporary path. This addition changes the path of files that is preserved by the zipping process.This results in an incorrect path on the Ghost instance once uploaded, as the import process preserves paths.