Skip to content

TRITON-2513 - Update Access Keys to better support Manta S3 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
travispaul wants to merge 16 commits into
base: master
Choose a base branch
from
Open

TRITON-2513 - Update Access Keys to better support Manta S3 #153

travispaul wants to merge 16 commits into from

Conversation

@travispaul
Copy link
Member

@travispaul travispaul commented Oct 27, 2025 •
edited
Loading

Updates to existing AccessKey support:

  • Filtering out unwanted dn, objectclass, and controls properties.
  • Only returning accesskeysecret upon key creation of an AccessKey.
  • Support for updating the status and description properties for AccessKeys.
  • Update endpoints
  • Limit number of accesskeys that can be created (100)

travispaul
travispaul commented Oct 27, 2025
View reviewed changes
travispaul
travispaul commented Oct 27, 2025
View reviewed changes
@travispaul travispaul mentioned this pull request Oct 28, 2025
Merged
danmcd
danmcd reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkpointing.

cneira
cneira requested changes Oct 29, 2025
View reviewed changes
lib/endpoints/accesskeys.js Outdated
}

try {
ufds.updateAccessKey(user, account, params, function (err, accesskey) {
Copy link

@cneira cneira Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that access keys have the description property, which can be updated along with access keys' status, I think we do not need to make the modify method from a NOP to handle this in MAHI properly. I could be wrong, though.

Copy link
Member Author

@travispaul travispaul Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds accurate to me. I'll install TritonDataCenter/mahi/pull/25 and look at that a bit more in depth today.

Copy link
Contributor

@danmcd danmcd Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 is MANTA-5475 for those who organize by bugid.

Copy link
Member Author

@travispaul travispaul Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the necessary changes to Mahi: TritonDataCenter/mahi/pull/26

@cneira cneira self-requested a review October 29, 2025 11:51
@travispaul travispaul mentioned this pull request Oct 29, 2025
Merged
@travispaul travispaul mentioned this pull request Nov 17, 2025
Open
@travispaul travispaul mentioned this pull request Dec 2, 2025
Open
@travispaul travispaul mentioned this pull request Dec 5, 2025
Merged
cneira
cneira reviewed Dec 6, 2025
View reviewed changes
danmcd
danmcd reviewed Dec 11, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass-0, and I know this is still in Draft-PR state.

@travispaul travispaul marked this pull request as ready for review December 17, 2025 00:26
@travispaul travispaul requested review from cneira and danmcd December 17, 2025 00:27
danmcd
danmcd reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental update.

danmcd
danmcd reviewed Dec 17, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I think. I have Y2038 anxiety, but that's not a blocker for this unless you expect some lifetimes to exceed Y2038 expiration time.

danmcd
danmcd approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not push without @cneira approval, but my concerns have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmcd danmcd danmcd approved these changes

@cneira cneira Awaiting requested review from cneira

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travispaul @danmcd @cneira