feat: streaming response for HookedTransformer.generate#847
Closed
hijohnnylin wants to merge 5 commits intoTransformerLensOrg:devfrom
Closed
feat: streaming response for HookedTransformer.generate#847hijohnnylin wants to merge 5 commits intoTransformerLensOrg:devfrom
hijohnnylin wants to merge 5 commits intoTransformerLensOrg:devfrom
Conversation
Author
|
still a draft as I have not written docs, tests, etc. |
Author
|
the current implementation breaks existing calls where stream_output is false because |
Collaborator
|
Very nice! Looking forward to messing around with this. I will keep an eye out for a test, and then we can get it into a build right away. |
7 tasks
Collaborator
|
Is this still relevant, or are we passing on this in favor of #908? |
Author
|
This can be closed. THanks!
… On May 7, 2025, at 9:23 AM, Bryce Meyer ***@***.***> wrote:
bryce13950
left a comment
(TransformerLensOrg/TransformerLens#847)
<#847 (comment)>
Is this still relevant, or are we passing on this in favor of #908 <#908>?
—
Reply to this email directly, view it on GitHub <#847 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH6NEXNFHJ2ZE47BHQYI4325IXPTAVCNFSM6AAAAABWGHWUR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJZGIZDEOJVGA>.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a
stream_outputflag (defaultFalse) to HookedTransformer.generate which streams the tokens as they're generated, instead of waiting for the whole result to be generated first.Type of change
Please delete options that are not relevant.
Checklist: