Skip to content

send a response if the cgi script failed #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamholz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

send a response if the cgi script failed #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c9b2ce
send a response if the cgi script failed
kamholz Oct 26, 2014
acd454a
add timeout option to kill hung scripts
kamholz Jan 5, 2015
a8870fe
Merge remote-tracking branch 'upstream/master'
kamholz Sep 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cgi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,14 @@ function cgi(cgiBin, options) {
var cgiSpawn = spawn(cgiBin, opts.args, opts);
debug('cgi spawn (pid: %o)', cgiSpawn.pid);

var exited = false;

if (options.timeout) {
setTimeout(function() {
if (!exited) cgiSpawn.kill();
}, options.timeout * 1000);
}

// The request body is piped to 'stdin' of the CGI spawn
req.pipe(cgiSpawn.stdin);

Expand Down Expand Up @@ -146,6 +154,7 @@ function cgi(cgiBin, options) {

cgiSpawn.on('exit', function(code, signal) {
debug('cgi spawn %o "exit" event (code %o) (signal %o)', cgiSpawn.pid, code, signal);
exited = true;
// TODO: react on a failure status code (dump stderr to the response?)
});

Expand All @@ -154,6 +163,11 @@ function cgi(cgiBin, options) {
debug('cgi spawn %o stdout "end" event', cgiSpawn.pid);
if (cgiResult) {
cgiResult.cleanup();
if (!res.headersSent) {
res.writeHead(500, { 'Content-type': 'text/plain' });
res.write('Internal Server Error');
res.end();
}
}
//if (options.stderr) {
// cgiSpawn.stderr.unpipe(options.stderr);
Expand Down