Skip to content

fix: DynamicVoiceChat deleting channel without checking if members are in there #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tj-wazei merged 1 commit into from
Jan 26, 2026
Merged

fix: DynamicVoiceChat deleting channel without checking if members are in there #1395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ private void handleVoiceChannelLeave(AudioChannelUnion channelLeft) {
if (!eventHappenOnDynamicRootChannel(channelLeft)) {
logger.debug("Event happened on left channel {}", channelLeft);

if (hasMembers(channelLeft)) {
logger.debug("Voice channel {} not empty, so not doing anything.",
channelLeft.getName());
return;
}

channelLeft.asVoiceChannel().getHistory().retrievePast(2).queue(messages -> {
if (messages.size() > 1) {
archiveDynamicVoiceChannel(channelLeft);
Expand Down Expand Up @@ -124,16 +130,13 @@ private void moveMember(Guild guild, Member member, AudioChannel channel) {
member.getNickname(), channel.getName(), error));
}

private boolean hasMembers(AudioChannelUnion channel) {
return !channel.getMembers().isEmpty();
}

private void archiveDynamicVoiceChannel(AudioChannelUnion channel) {
int memberCount = channel.getMembers().size();
String channelName = channel.getName();

if (memberCount > 0) {
logger.debug("Voice channel {} not empty ({} members), so not removing.", channelName,
memberCount);
return;
}

Optional<Category> archiveCategoryOptional = channel.getGuild()
.getCategoryCache()
.stream()
Expand Down
Loading