Skip to content

Fixes to #135#136

Open
TkTech wants to merge 9 commits intomasterfrom
lemire-master
Open

Fixes to #135#136
TkTech wants to merge 9 commits intomasterfrom
lemire-master

Conversation

@TkTech
Copy link
Owner

@TkTech TkTech commented Feb 18, 2026

No description provided.

@TkTech
Copy link
Owner Author

TkTech commented Feb 18, 2026

@lemire this is updating your #135 PR. Is simdjson still tested under C++11? It's currently broken and requires C++17 if the header is used multiple times.

 SIMDJSON_CONSTEXPR_LAMBDA void escape_json_char(char c, char *&out) { ... }

I believe what's happening here is that in C++17 SIMDJSON_CONSTEXPR_LAMBDA is constexpr, which will inline. So importing it twice is fine. On C++11, the macro expands to nothing so it's just a regular header-defined function which will conflict with any other object that also imported simdjson.h.

@lemire
Copy link
Contributor

lemire commented Feb 18, 2026

@TkTech Ah. Makes sense. This looks like a simdjson bug.

@lemire
Copy link
Contributor

lemire commented Feb 18, 2026

I’ll work on a patch

@lemire
Copy link
Contributor

lemire commented Feb 18, 2026

Once the PR simdjson/simdjson#2606 goes green, I will issue a release.

@lemire
Copy link
Contributor

lemire commented Feb 20, 2026

@TkTech Please update to 4.3.1, there should be no issue:

https://github.com/simdjson/simdjson/releases/tag/v4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants