🐛 Fix WSI Reading#1076
Open
shaneahmed wants to merge 7 commits into
Open
Conversation
Member
shaneahmed
commented
Jun 8, 2026
- On Windows urlparse would converts the input to str causing WSI reading to fail
- s3 links to test cloud ngff read is also fixed.
- On Windows urlparse would convert the input to str causing WSI reading to fail - s3 links to test cloud ngff read is also fixed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failures when opening NGFF/Zarr WSIs from URL-like paths on Windows by improving URL/path handling and ensuring Zarr open calls receive needed storage options (notably for S3-backed reads).
Changes:
- Switches WSIReader path normalization to
UPathto avoid Windowspathlibmangling ofs3://...paths. - Updates NGFF detection to forward reader kwargs into
zarr.open(...)(to supportstorage_optionsfor cloud stores). - Updates the S3 NGFF test endpoint URL and adds an
s3fsruntime dependency.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tiatoolbox/wsicore/wsireader.py |
Adds UPath normalization, introduces is_url, and forwards kwargs into NGFF/Zarr open paths. |
tests/test_wsireader.py |
Updates the S3 test endpoint URL for NGFF read validation. |
requirements/requirements.txt |
Adds s3fs dependency for S3 filesystem support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1076 +/- ##
===========================================
- Coverage 99.88% 99.87% -0.02%
===========================================
Files 85 85
Lines 11626 11631 +5
Branches 1524 1524
===========================================
+ Hits 11613 11616 +3
- Misses 7 9 +2
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.