Record progress updates for direct container sends #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Oct 28, 2025
| /// This is not a validated capability, and this method should not be used without great care. | ||
| /// Ideally, users would not have direct access to a `Counter`, and preventing this is the way | ||
| /// to uphold invariants. | ||
| #[inline] pub fn give<C: crate::Container>(&mut self, time: T, container: &mut C) where P: Push<Message<T, C>> { |
Member
There was a problem hiding this comment.
We should remove this function in a follow-up PR, but not here. Let's keep this compatible with the currently release version.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pushers::Countertype has a methodgive<C>that ships a container usingMessage::push_at. However, it targetsself.pushee, rather thanself. Doing so, it bypasses the accounting of the pushed container, causing unknown downstream misery. The doccomments for the method suggest that it probably shouldn't be used, though I think the intent was that it wouldn't be so certainly incorrect.