More VecCollection demotion#667
Merged
frankmcsherry merged 3 commits intoTimelyDataflow:masterfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves two hunks of
VecCollectionlogic around, namely:consolidate.rsfile had a few line implementations of consolidation exclusively forVecCollection. These are inherent methods, and were just relocated tocollection::vec.arrangement.rstraitsArrangeBySelfandArrangeByKeywere implemented forVecCollection, and imported all over the place just to get access to their methods. They have become inherent methods, the traits deleted, and references to the traits removed (all were just to access the methods, not to use the traits themselves for anything other than method resolution).Pausing here as it is a lot of churn, and the next steps are .. maybe less obvious and less uncontroversial.