Skip to content

Conversation

@frankmcsherry
Copy link
Member

This PR introduces traits Negate, Enter, Leave, and ResultsIn for containers, such that collections based around containers implementing each of these traits gets access to the corresponding methods.

@frankmcsherry
Copy link
Member Author

In principle this should be extendable to the Iterate trait, but .. it's a bit weird in that the trait now needs to name two container types, the "returned" type and the "iterated" type. All possible, but a bit wordy and perhaps the next steps should be to adapt examples/columnar.rs to use variables first, to ensure that the traits check out.

Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

antiguru and others added 3 commits September 24, 2025 17:26
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@frankmcsherry frankmcsherry marked this pull request as ready for review September 26, 2025 15:35
@frankmcsherry frankmcsherry merged commit 1e242f6 into TimelyDataflow:master Sep 26, 2025
5 checks passed
@frankmcsherry frankmcsherry deleted the container_traits branch September 26, 2025 15:40
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants